Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve i18n for formatting memory size #2401

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Conversation

int-y1
Copy link
Contributor

@int-y1 int-y1 commented Jan 5, 2025

this will use the correct decimal separator for certain languages. example:

Screenshot 2025-01-05 151942

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 47.72%. Comparing base (fd7fb05) to head (830e90c).
Report is 64 commits behind head on master.

Files with missing lines Patch % Lines
judge/jinja2/filesize.py 25.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2401      +/-   ##
==========================================
+ Coverage   46.76%   47.72%   +0.95%     
==========================================
  Files         251      259       +8     
  Lines       13317    13712     +395     
==========================================
+ Hits         6228     6544     +316     
- Misses       7089     7168      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kiritofeng kiritofeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@kiritofeng kiritofeng added this pull request to the merge queue Jan 5, 2025
Merged via the queue into DMOJ:master with commit 25f4798 Jan 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants