Add ppa:pypy/ppa repository in Dockerfiles of judgehost and gitlabci #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmcj
reviewed
Oct 5, 2024
| @@ -7,7 +7,8 @@ RUN useradd -d /nonexistent -g nogroup -s /bin/false domjudge-run-0 | |||
| RUN useradd -d /nonexistent -g nogroup -s /bin/false domjudge-run-1 | |||
| RUN groupadd domjudge-run | |||
|
|
|||
| RUN apt-get update && apt-get install -y \ | |||
| RUN apt-add-repository ppa:pypy/ppa -y \ | |||
| apt-get update && apt-get -y install \ | |||
There was a problem hiding this comment.
I rather test with the old version in the gitlab ci tests, we try to test DOMjudge here not if the ppa has connection issues or if they pushed a broken package.
I think we should always test with the oldest version someone could run, not with the version we normally use ourselves.
There was a problem hiding this comment.
That's a good point! And it also looks like the Docker build fails because it can't find the PPA. 😅 In that case, I'll close this PR 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that the
pypy3package is always the latest, which is nice for always having the newest possible Python language level. Currently, Ubuntu 24.04 (Noble Numbat) haspypy37.3.15 (with Python 3.9) and this will probably stay like this for a while, butpypy37.3.17 already supports Python 3.10.These were the only two occurrences of
apt-get install [...] pypy3 [...]that I could find, please let me know if I missed something. For example, I don't know how the judgehosts end up in the docker-contributor image.Also, for some reason,
docker/judgehost/Dockerfile.chrootwas still based on Ubuntu 20.04, so I also updated that 🙂