Add nightly updates of BTFs #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
brycekahle
commented
Jan 10, 2024
brycekahle
commented
- ports debian, ubuntu, centos, fedora, and oracle from aquasecurity/btfhub
- adds Amazon Linux 1 and 2
usamasaqib
reviewed
Jan 11, 2024
| FORCE_UNSAFE_CONFIGURE=1 ./configure --prefix=/ | ||
| make install | ||
|
|
||
| - name: install newer clang |
There was a problem hiding this comment.
There are some cgo parts in btfhub that need it.
| steps: | ||
| - name: Install needed amazon packages | ||
| run: | | ||
| yum install -y yum-utils wget tar gzip xz clang make cmake git libdwarf-devel elfutils-libelf-devel elfutils-devel |
There was a problem hiding this comment.
Version of clang does not matter for our usecase?
There was a problem hiding this comment.
It does, btfhub doesn't compile with the older version of clang that is available via a yum package, and conversely I was having trouble getting elfutils and tar building with the newer clang (probably because I did a manual install).
usamasaqib
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.