Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump v1.18.0_rc3 #432

Merged
merged 53 commits into from
Jan 1, 2024
Merged

bump v1.18.0_rc3 #432

merged 53 commits into from
Jan 1, 2024

Conversation

Der-Henning
Copy link
Owner

Pull Request Checklist

  • Have you checked to ensure there aren't other open
    Pull Requests for the same update/change?
  • Did you make your Pull Request on the dev branch?
  • Does your submission pass tests? make test
  • Have you lint your code locally prior to submission? make lint
  • Could you build and run the docker image successfully? make image
  • Could you create a running executable? make executable
  • Have you added an explanation of what your changes do
    and why you'd like to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran manual tests with your changes locally?

Copy link

codecov bot commented Jan 1, 2024

Codecov Report

Attention: 231 lines in your changes are missing coverage. Please review.

Comparison is base (acc2fa7) 75.06% compared to head (b276b4a) 64.81%.
Report is 1 commits behind head on main.

Files Patch % Lines
tgtg_scanner/notifiers/telegram.py 57.73% 71 Missing ⚠️
tgtg_scanner/models/config.py 93.63% 31 Missing ⚠️
tgtg_scanner/__main__.py 0.00% 30 Missing ⚠️
tgtg_scanner/scanner.py 0.00% 27 Missing ⚠️
tgtg_scanner/tgtg/tgtg_client.py 63.33% 11 Missing ⚠️
tgtg_scanner/notifiers/base.py 77.27% 10 Missing ⚠️
tgtg_scanner/notifiers/push_safer.py 41.17% 10 Missing ⚠️
tgtg_scanner/notifiers/smtp.py 83.33% 8 Missing ⚠️
tgtg_scanner/notifiers/notifiers.py 46.15% 7 Missing ⚠️
tgtg_scanner/_version.py 0.00% 6 Missing ⚠️
... and 7 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #432       +/-   ##
===========================================
- Coverage   75.06%   64.81%   -10.25%     
===========================================
  Files          32       26        -6     
  Lines        1985     2197      +212     
===========================================
- Hits         1490     1424       -66     
- Misses        495      773      +278     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Der-Henning Der-Henning merged commit e2e3611 into main Jan 1, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant