-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2.11.1] Switch to new iris >= 3.10.0 API #2500
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2500 +/- ##
=======================================
Coverage 94.69% 94.70%
=======================================
Files 248 248
Lines 14071 14001 -70
=======================================
- Hits 13324 13259 -65
+ Misses 747 742 -5 ☔ View full report in Codecov by Sentry. |
excellent, many thanks for taking on this one, Manu! Lemme know when you need a review 🍺 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just adding a placeholder review suggestion so we don't end up with that iris RC channel in main
😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remember to pin it in setup.py too
Co-authored-by: Valeriu Predoi <valeriu.predoi@gmail.com>
Co-authored-by: Valeriu Predoi <valeriu.predoi@gmail.com>
Since iris released v.3.10.0 today, this is ready for review now! |
will do a more reviewey review tomorrow, in the meantime, be advised of this for future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no problems at all from my side, very nice and sound PR, Manu 🍺 Only thing we have to be careful is if anyone develops a diagnostic using the main
of ESMValCore (so in full development way) then wants it deployed in Tool - we'll have to tell them to wait for a Core release, but let's bridge that bridge if we get there
@bouweandela please merge if you're happy with this 👍 |
Thanks V for reviewing 🍻 |
Co-authored-by: Valeriu Predoi <valeriu.predoi@gmail.com> (cherry picked from commit 412ac53)
Description
Iris introduces a couple new features and also some breaking changes in v3.10.0:
iris.experimental.ugrid
is deprecated in favor foriris.mesh
Mesh
is now calledMeshXY
MeshXY.coord()
have changedbroadcast_to_shape
now supportschunk
argument (we can remove our custom solution)area_weights
calculation is now lazy (we can remove our custom solution)I opted for pinning iris instead of making it backwards-compatible so we can use all new features, which allows us to remove lots of lines in our code.
Addresses #2492
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: