Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.11.1] Switch to new iris >= 3.10.0 API #2500

Merged
merged 14 commits into from
Aug 14, 2024
Merged

[v2.11.1] Switch to new iris >= 3.10.0 API #2500

merged 14 commits into from
Aug 14, 2024

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Aug 2, 2024

Description

Iris introduces a couple new features and also some breaking changes in v3.10.0:

  • iris.experimental.ugrid is deprecated in favor for iris.mesh
  • Mesh is now called MeshXY
  • Keyword arguments for MeshXY.coord() have changed
  • broadcast_to_shape now supports chunk argument (we can remove our custom solution)
  • area_weights calculation is now lazy (we can remove our custom solution)

I opted for pinning iris instead of making it backwards-compatible so we can use all new features, which allows us to remove lots of lines in our code.

Addresses #2492


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added the iris Related to the Iris package label Aug 2, 2024
@schlunma schlunma added this to the v2.12.0 milestone Aug 2, 2024
@schlunma schlunma self-assigned this Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.70%. Comparing base (f969e82) to head (3a7a180).
Report is 48 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2500   +/-   ##
=======================================
  Coverage   94.69%   94.70%           
=======================================
  Files         248      248           
  Lines       14071    14001   -70     
=======================================
- Hits        13324    13259   -65     
+ Misses        747      742    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valeriupredoi
Copy link
Contributor

excellent, many thanks for taking on this one, Manu! Lemme know when you need a review 🍺

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just adding a placeholder review suggestion so we don't end up with that iris RC channel in main 😁

environment.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remember to pin it in setup.py too

environment.yml Outdated Show resolved Hide resolved
schlunma and others added 4 commits August 13, 2024 16:33
Co-authored-by: Valeriu Predoi <valeriu.predoi@gmail.com>
Co-authored-by: Valeriu Predoi <valeriu.predoi@gmail.com>
@schlunma
Copy link
Contributor Author

Since iris released v.3.10.0 today, this is ready for review now!

@schlunma schlunma marked this pull request as ready for review August 13, 2024 15:11
@valeriupredoi
Copy link
Contributor

will do a more reviewey review tomorrow, in the meantime, be advised of this for future rc_iris stuffs conda-forge/iris-feedstock#115

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problems at all from my side, very nice and sound PR, Manu 🍺 Only thing we have to be careful is if anyone develops a diagnostic using the main of ESMValCore (so in full development way) then wants it deployed in Tool - we'll have to tell them to wait for a Core release, but let's bridge that bridge if we get there

@schlunma
Copy link
Contributor Author

@bouweandela please merge if you're happy with this 👍

@schlunma
Copy link
Contributor Author

Thanks V for reviewing 🍻

@bouweandela bouweandela removed the iris Related to the Iris package label Aug 14, 2024
@bouweandela bouweandela added the installation Installation problem label Aug 14, 2024
@bouweandela bouweandela merged commit 412ac53 into main Aug 14, 2024
6 checks passed
@bouweandela bouweandela deleted the new_iris_api branch August 14, 2024 16:41
schlunma added a commit that referenced this pull request Nov 15, 2024
Co-authored-by: Valeriu Predoi <valeriu.predoi@gmail.com>
(cherry picked from commit 412ac53)
@schlunma schlunma changed the title Switch to new iris >= 3.10.0 API [v2.11.1] Switch to new iris >= 3.10.0 API Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation Installation problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants