Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation build and broken link #2519

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Fix documentation build and broken link #2519

merged 2 commits into from
Sep 9, 2024

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Sep 9, 2024

Description

The documentation build is broken since #2457 was merged because it included a broken reference. This pull request fixes the reference and also the broken link reported in #2510.

Closes #2510.

Link to documentation: https://esmvaltool--2519.org.readthedocs.build/projects/ESMValCore/en/2519/


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela added the documentation Improvements or additions to documentation label Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.77%. Comparing base (2247a29) to head (23a9967).
Report is 57 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2519   +/-   ##
=======================================
  Coverage   94.77%   94.77%           
=======================================
  Files         249      249           
  Lines       14081    14081           
=======================================
  Hits        13345    13345           
  Misses        736      736           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bouweandela bouweandela marked this pull request as ready for review September 9, 2024 09:27
Copy link
Contributor

@sloosvel sloosvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, all links work fine now

@bouweandela bouweandela merged commit 21ce35a into main Sep 9, 2024
6 checks passed
@bouweandela bouweandela deleted the fix-docs-build branch September 9, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link to CF standard name table
2 participants