Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Updated the QuickStart-JSON documentation with new BioDrop images #9714

Merged
merged 34 commits into from
Nov 5, 2023
Merged

Updated the QuickStart-JSON documentation with new BioDrop images #9714

merged 34 commits into from
Nov 5, 2023

Conversation

goobric
Copy link
Contributor

@goobric goobric commented Nov 2, 2023

Fixes Issue

Closes #9697

Changes proposed

  • updated the quickstart-json documentation to reflect the new brand of BioDrop
  • the user will now see the corresponding images during their creation of a BioDrop profile
  • updated the relevant images for the new brand BioDrop where applicable
  • updated the text where appropriate to correspond to the new images
  • the changes have been made to a new branch names 'qsjson'

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

qsjson01
qsjson02
qsjson03
qsjson04
qsjson05
qsjson06
qsjson07
qsjson08
see attached screen images to support the changes

Note to reviewers

Where and How, do I perform tests, on my proposed changes?? '[] All new and existing tests passed'
Note about the images:

  • the images that were provided, with BioDrop, I added a red rectangle to those whose words that needed emphasising to the user.
  • as I wasn't able to reference these images via a url-link; I wanted to place them within an assets/images directory; but I couldn't locate one. Therefore I created an 'images' directory within the 'docs' folder, and placed the new images in there, and reference them within the mdx file. Sorry if this was not the correct process :-/
  • As requested, I removed the current image that was associated with step19

goobric added 24 commits November 1, 2023 09:19
@goobric
updated step2 img
751e61a
@goobric
updated step5 img
411cd31
@goobric
updated step7 img
264a37d
@goobric
updated step17 img
437f283
@goobric
updated text in step7 to reflect the image used in step7
16cff3e
@goobric
updated text in step7 for example user
25acd74
@goobric
corrected typo in step7
474a492
@goobric
updated step8 clipboard text
e6a8a33
@goobric
upadated step9 clipboard text
8a847b3
@goobric
updated step9 links text
1960c53
@goobric
created images directory
a9b0c97
@goobric
add images for step5
5bf5cb5
@goobric
added image for step4 -04
6e436bc
@goobric
image for step5
7f244ce
@goobric
image for step9
e9d9f1f
@goobric
added image for step12
0d4359c
@goobric
amended step10 text for new image in step12
1d00a5d
@goobric
added red border to propose new file
d08ee6f
@goobric
amended text in step12 for new image in step12
dad597e
@goobric
added new image for step15
7d4940f
@goobric
new image for step15
f23c389
@goobric
new link for image for step15
d65e5c5
@goobric
updated text for step19
6f1312d
@goobric
removed image associated with step19
4b6fc7e
@goobric goobric requested a review from SaraJaoude as a code owner November 2, 2023 19:59
@github-actions github-actions bot added issue linked Pull Request has issue linked 📖 docs Documentation pages and removed issue linked Pull Request has issue linked labels Nov 2, 2023
@Abhishek-90 Abhishek-90 mentioned this pull request Nov 3, 2023
Closed
1 task
@github-actions github-actions bot added the issue linked Pull Request has issue linked label Nov 3, 2023
eddiejaoude
eddiejaoude approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you 👍

@eddiejaoude eddiejaoude merged commit dac63b4 into EddieHubCommunity:main Nov 5, 2023
malay44 pushed a commit to malay44/BioDrop that referenced this pull request Nov 9, 2023
@goobric @eddiejaoude @malay44
fix: quickstart json docs with biodrop images (EddieHubCommunity#9714)
8f715ec 
* updated step2 img

* updated step5 img

* updated step7 img

* updated step17 img

* updated text in step7 to reflect the image used in step7

* updated text in step7 for example user

* corrected typo in step7

* updated step8 clipboard text

* upadated step9 clipboard text

* updated step9 links text

* created images directory

* add images for step5

* added image for step4 -04

* image for step5

* image for step9

* added image for step12

* amended step10 text for new image in step12

* added red border to propose new file

* amended text in step12 for new image in step12

* added new image for step15

* new image for step15

* new link for image for step15

* updated text for step19

* removed image associated with step19

* added gh img link to step3, removed_03 img from images

* add gh img link step4, removed _04 img

* add gh img link step5, removed _05 img

* add gh img link step12, removed _e5f8 img

* add gh img link step15, removed _15 img

* removed images dir from docs

* added original image for step19

* updated img link for step9

* Update pages/docs/quickstart-json.mdx

* Update pages/docs/quickstart-json.mdx

---------

Co-authored-by: Eddie Jaoude <eddie@jaoudestudios.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eddiejaoude eddiejaoude eddiejaoude approved these changes

@SaraJaoude SaraJaoude Awaiting requested review from SaraJaoude

Assignees
No one assigned
Labels
📖 docs Documentation pages issue linked Pull Request has issue linked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BioDrop Images] <change LinkFree images in QuickStart JSON guide>
2 participants
@goobric @eddiejaoude