-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Database cleanup pipeline #964
Draft
nwillhoft
wants to merge
190
commits into
Ensembl:release/mvp
Choose a base branch
from
nwillhoft:feature/db_cleanup_pipeline
base: release/mvp
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Database cleanup pipeline #964
nwillhoft
wants to merge
190
commits into
Ensembl:release/mvp
from
nwillhoft:feature/db_cleanup_pipeline
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recompiled dependencies to use hive default branch.
* Added a failure if gzip fails to complete properly * Switched backtick gzip to perl package in mysqldump and dumpfile * bugfix * revert and fixed the compress calls * revert and fixed the compress calls * unpack the arrayref to array * fixed flat file to pass array reference. * Removed automatic flow for tsvs * Readded flow to tsvs and fixed bug with a conditional * Readded param_required and added optional flow * Swapped array is empty test for a better one * removed array test as the files should alwalys be generated * Swapped array is empty test for a better one and fixed flow * Modified array ref --------- Co-authored-by: vinay-ebi <vinay@ebi.ac.uk>
fix data_files path removig the vertebrates folder
Fix symlink path
…ease/111 # Conflicts: # requirements.txt
Release/merge 111
Updating test dbs to latest schema
Add gencode primary tag to GFF3 files
Updated download URL for miRBase miRNA.dat file
Updated download URL for miRBase miRNA.dat file
Updated .gitignore + patch DQ forgotten when initially branching
…-fixes-110 # Conflicts: # scripts/py/regulation_ftp_symlinks.py
Bugfixes/merge fixes 110
Co-authored-by: Tamara El Naboulsi <ten@codon-login-06.ebi.ac.uk>
Updated Core stats resources.
Hotfix/xref TSV dump
Report from main
…s we actually requested 9. Added SLURM specifications
dpopleton
previously approved these changes
Feb 4, 2025
dpopleton
dismissed
their stale review
February 4, 2025 15:01
Should have failed it for merging to the wrong branch
dpopleton
requested changes
Feb 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should merge into release/mvp. Not main.
We could also do main, if that is your intention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DRAFT - Nextflow pipeline to clear up databases].
JIRA ticket: https://www.ebi.ac.uk/panda/jira/browse/ENSCORESW-4404
Description
A nextflow pipeline to export database SQL to file and store it. The source database can optionally be deleted if required to free up storage space.
Use case
If a db host contains any old/unused dbs, this pipeline can be used to dump out their SQL, put the files in a convenient place and remove the db.
Example of how to run the pipeline:
Benefits
This pipeline will make it easier to automate the removal of old dbs.
Possible Drawbacks
Not an intended drawback but running the pipeline on more than 1 db at a time appears to cause a bottleneck in the dbcopy-client processing. This needs testing out further as the pipeline is set up to process everything in parallel to be as efficient as possible. To give an example, I tried copying over 3 dbs from
st6
tocore-prod-1
and it took over 24 hours to perform only the copy step. Whereas if I try coping 1 db at a time, it typically takes around an hour or less for this step.Testing
Dependencies
The only external code dependency is using
plugin/nf-schema
within nextflow.