Release 2023-11-28 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those cases are new due to forceConsistentCasingInFileNames
Quite a bit of `as`, but I think that is fine here.
> Warning: For production Image Optimization with Next.js, the optional 'sharp' package is strongly recommended. Run 'npm i sharp', and Next.js will use it automatically for Image Optimization. > Read more: https://nextjs.org/docs/messages/sharp-missing-in-production
Trying NEXT_PUBLIC_ENV to show up.
Lets see if this helps in making the ENV available.
Next test… lets see if maybe the name is the issue.
This reverts commit b9c64aa.
OK, lets hope this works…
This does guard the application against undefined states where the initial URL is invalid. However, it also causes weird state effects. 1. Open page with broken config-param 2. App fixes the config-param and renders fine but does not fix the URL 3. Only once the user triggers a setConfig, the fixed URL is populated
Makes the code reusable.
… `config` params
We use useStaticRegion only for useConfigParam and useMapParam ATM and both are used in the header where no region is present. In those cases, the helper need to initialize withDefaults in order for the application to render. We do not actually use those params afterwards.
There are situations, when all our guards are not enough and `mainMap.getStyle()` still errors. One way to force this is: (1) open /regionen/bibi, (2) Goto "Acount bearbeiten", (3) Save the form, (4) Use the browser back to show the map again.
This did not work which is why we are now using server components for the page.tsx files and the NextJS metadata API.
…karound See code comment for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.