-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply custom message in login dialog on direct access #332
Conversation
@knolleary not sure if you noticed test fail following removal of |
@Steve-Mcl test fix pushed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps |
Have updated the message to |
Fixes https://github.com/FlowFuse/node-red/issues/25
This PR removes the username/password fields from the login dialog when the editor is accessed directly. We get support requests asking what credentials to use - however we only support accessing the editor via the device agent proxy.
With NR 4.0.6 (to be released imminently), I've added the ability to insert a custom message/button on the login dialog when in this state. Older versions of NR will show a blank dialog.
Note: spotted the
dashbaord
typo when I took this screenshot for the PR... it will be fixed momentarily.