Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply custom message in login dialog on direct access #332

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Conversation

knolleary
Copy link
Member

Fixes https://github.com/FlowFuse/node-red/issues/25

This PR removes the username/password fields from the login dialog when the editor is accessed directly. We get support requests asking what credentials to use - however we only support accessing the editor via the device agent proxy.

With NR 4.0.6 (to be released imminently), I've added the ability to insert a custom message/button on the login dialog when in this state. Older versions of NR will show a blank dialog.

image

Note: spotted the dashbaord typo when I took this screenshot for the PR... it will be fixed momentarily.

@knolleary knolleary requested a review from Steve-Mcl December 17, 2024 16:38
@Steve-Mcl
Copy link
Contributor

@knolleary not sure if you noticed test fail following removal of type?

@knolleary
Copy link
Member Author

@Steve-Mcl test fix pushed

Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested/working/approved

This is how it looks on Win + Chrome

image

Aesthetically, I do wish the string didn't wrap on the last word (but at the same time I cant think of a better way to phrase it)

@Steve-Mcl
Copy link
Contributor

Aesthetically, I do wish the string didn't wrap on the last word (but at the same time I cant think of a better way to phrase it)

Perhaps 'Access to the editor is managed via FlowFuse' would be a suitable (shorter, non wrapping) alternative?

@knolleary
Copy link
Member Author

Have updated the message to Access the editor through the FlowFuse platform

@knolleary knolleary merged commit bf258f3 into main Dec 18, 2024
4 checks passed
@knolleary knolleary deleted the login-message branch December 18, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants