Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rails 8.0 #99

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Conversation

k-tsuchiya-jp
Copy link

@k-tsuchiya-jp k-tsuchiya-jp commented Nov 11, 2024

Motivation / Background

Support rails 8.0

Detail

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Unrelated changes should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@k-tsuchiya-jp
Copy link
Author

$ ruby test.rb

Testing with ruby version 3.3.6

Testing with Active Record version 8.0.0

Testing with Action Pack version 8.0.0

Run options: --seed 55055

# Running:

......................................

Finished in 0.217141s, 175.0015 runs/s, 257.8969 assertions/s.

38 runs, 56 assertions, 0 failures, 0 errors, 0 skips

@jrafanie
Copy link
Collaborator

Thanks @k-tsuchiya-jp. I've pushed a commit to get rails 8.0 into the CI test matrix.

@jrafanie jrafanie self-assigned this Nov 11, 2024
@jrafanie jrafanie merged commit ba66b84 into FooBarWidget:master Nov 11, 2024
17 checks passed
@jrafanie
Copy link
Collaborator

Released in 4.1.0. Please report any bugs or problems! Thanks for the contribution.

@k-tsuchiya-jp
Copy link
Author

@jrafanie
Thank you for review, merge, and also for adding the changes to ci.yaml.
I really appreciate you going as far as handling the release – it was a great help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants