-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fault_proving(compression): include commitment to transaction ids within compressed block header #2572
base: master
Are you sure you want to change the base?
Conversation
7fffaa2
to
d2d2248
Compare
4d998ae
to
4ca0445
Compare
d2d2248
to
62b882d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks alright to me. Would be nice to have test coverage of this computation.
…hin compressed block header
62b882d
to
3e090b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no comment from my side, looks in good shape
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see how it is useful for us to store hash of all transaction ids in the CompressedHeader. I see how it can be used while it is in the regular header(because we can prove that it is part of the block id, and block id is our main connection point with the block). While in the case of the compressed header, we only can prove that compressed header contains the hash of the some decompressed transactions, these transactions are not connected to the block.
when the user performs decompression, they end up with a |
Linked Issues/PRs
closes #2569 and closes #2574
Description
instead of the merkle root of transaction ids, we directly commit to a hash of all tx ids ordered as they are in the block.
Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]