Abi errors RFC

[IGI-111]

Rendered

[hal3e]

Great rfc. This should make the devx so much better.

• I would like to work on this on the rust sdk side.

[tritao]

It looks great and a really welcome improvement to error handling.

The only concern I have is how the syntax at the moment is directed specifically towards ABI error handling, and this functionality seems like it could be pretty useful just as a general error-handling functionality as well, without necessarily being ABI-specific. This ABI terminology feels like it would be a bit out of place if in the future we have some other targets outside the Fuel VM in which the ABI meaning is not as clear-defined.

What if we made the terminology around this a bit more generic, like Rust, specifically an Error trait analogous to Rust std::error::Error, equivalent to your AbiError.

The main direct issue I can see with this is that if we also dropped abi_ prefix from abi_error attribute, then we would have a clash between error for the main error attribute and error attribute for each individual enum cases.

Rust side steps that issue by using derive instead, which could work for this as well, and would prevent a special attribute like abi_error, we would just use derive(Error). We would need to pick up on FuelLabs/sway#2396 and get the basic derive machinery in place.

[IGI-111]

I deliberately didn't want to use "derive", but I'm not opposed to renaming the trait to Error and finding a better name for the type annotation.

Maybe #[error_type]?

[alfiedotwtf]

Looks good and makes sense. Fix the typo and I'm happy to approve :)

[kayagokalp]

Looks great to me! This will be a big step forward in error handling.

Other than two spelling typos shown in:

https://github.com/FuelLabs/sway-rfcs/pull/43/files#r1857256227
https://github.com/FuelLabs/sway-rfcs/pull/43/files#r1857482020

It seems good to go to me!

[JoshuaBatty]

Really great work on this.

[esdrubal]

The specification seems to solve all the problems with current reverts, adding msg outputs and line number information to the ABI json. Nice work!

[ironcev]

Great proposal! Straightforward to implement and brings a huge benefit. This is a kind of low hanging fruit I wish we identify more.

[maschad]

Great work on this @IGI-111

Not strong opinion on this suggestion so feel free to resolve if you don't think it makes the intention clearer.

I'd give my explicit approval but compiler level changes are beyond my scope 😅

I approve in theory though 😄

[sdankel]

Great work, this is going to be a huge improvement! Just left a couple of suggestions/questions.