Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Attestations #1490

Merged
merged 16 commits into from
Jan 17, 2025
Merged

Add Attestations #1490

merged 16 commits into from
Jan 17, 2025

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Jan 14, 2025

@nojaf
Copy link
Contributor Author

nojaf commented Jan 14, 2025

I'm trying to run the attestation action for each digest.
See https://tomasvotruba.com/blog/2020/11/16/how-to-make-dynamic-matrix-in-github-actions/

@nojaf nojaf requested a review from jgiannuzzi January 15, 2025 12:59
@nojaf
Copy link
Contributor Author

nojaf commented Jan 15, 2025

Dear @jgiannuzzi, could you skim through this as well please?
Many thanks!

jgiannuzzi
jgiannuzzi reviewed Jan 15, 2025
View reviewed changes
Copy link
Member

@jgiannuzzi jgiannuzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of comment but the general approach LGTM

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
jgiannuzzi
jgiannuzzi reviewed Jan 16, 2025
View reviewed changes
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
pavlovic-ivan
pavlovic-ivan approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@pavlovic-ivan pavlovic-ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thx @nojaf

@nojaf nojaf merged commit 97e7440 into G-Research:main Jan 17, 2025
22 checks passed
nojaf added a commit that referenced this pull request Jan 31, 2025
@jgiannuzzi @dsuhinin
@dependabot @suprjinx @nojaf
Backport latest changes from main to release/0.7 (#1498)
1ae2afd 
* Fix problems related to latest postgres docker image (#1433)

Decrease the length of generated database name.

* Bump boto3 from 1.34.144 to 1.35.32 (#1434)

Bumps [boto3](https://github.com/boto/boto3) from 1.34.144 to 1.35.32.
- [Release notes](https://github.com/boto/boto3/releases)
- [Commits](boto/boto3@1.34.144...1.35.32)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump the github-com-aws-aws-sdk-go-v2 group across 1 directory with 3 updates (#1435)

Bumps the github-com-aws-aws-sdk-go-v2 group with 3 updates in the / directory: [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2), [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) and [github.com/aws/aws-sdk-go-v2/service/s3](https://github.com/aws/aws-sdk-go-v2).


Updates `github.com/aws/aws-sdk-go-v2` from 1.30.3 to 1.31.0
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@v1.30.3...v1.31.0)

Updates `github.com/aws/aws-sdk-go-v2/config` from 1.27.27 to 1.27.40
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@config/v1.27.27...config/v1.27.40)

Updates `github.com/aws/aws-sdk-go-v2/service/s3` from 1.58.2 to 1.64.1
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@service/s3/v1.58.2...service/s3/v1.64.1)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-com-aws-aws-sdk-go-v2
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-com-aws-aws-sdk-go-v2
- dependency-name: github.com/aws/aws-sdk-go-v2/service/s3
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-com-aws-aws-sdk-go-v2
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump google.golang.org/api from 0.188.0 to 0.199.0 (#1428)

Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.188.0 to 0.199.0.
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md)
- [Commits](googleapis/google-api-go-client@v0.188.0...v0.199.0)

---
updated-dependencies:
- dependency-name: google.golang.org/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump mlflow from 2.14.3 to 2.16.2 (#1424)

Bumps [mlflow](https://github.com/mlflow/mlflow) from 2.14.3 to 2.16.2.
- [Release notes](https://github.com/mlflow/mlflow/releases)
- [Changelog](https://github.com/mlflow/mlflow/blob/master/CHANGELOG.md)
- [Commits](mlflow/mlflow@v2.14.3...v2.16.2)

---
updated-dependencies:
- dependency-name: mlflow
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump black from 24.4.2 to 24.8.0 (#1377)

Bumps [black](https://github.com/psf/black) from 24.4.2 to 24.8.0.
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](psf/black@24.4.2...24.8.0)

---
updated-dependencies:
- dependency-name: black
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump cloud.google.com/go/storage from 1.43.0 to 1.44.0 (#1438)

Bumps [cloud.google.com/go/storage](https://github.com/googleapis/google-cloud-go) from 1.43.0 to 1.44.0.
- [Release notes](https://github.com/googleapis/google-cloud-go/releases)
- [Changelog](https://github.com/googleapis/google-cloud-go/blob/main/CHANGES.md)
- [Commits](googleapis/google-cloud-go@pubsub/v1.43.0...spanner/v1.44.0)

---
updated-dependencies:
- dependency-name: cloud.google.com/go/storage
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add aws default region (#1472)

* update to latest ui ref (#1181)

* Add a aws_default_region env var for dev/test

* Fix python tests (#1475)

* update to latest ui ref (#1181)

* Fix python integration tests

* Add Attestations (#1490)

* Test attestations

* Run release in fork

* Add attestations: write

* Move attestions to job level

* Move to job level?

* Permissions twice?

* Attest docker images

* Revert ci.yml change

* Move attestation to separate job

* Use correct output name

* Add dependency to docker-release

* Use different echo

* Code review jojo

* Fix errors

* Remove if

* Fix attestation generation (#1491)

* Add release environment to attest-docker-images (#1492)

* Login to Docker Hub before publishing container image attestations (#1493)

* Mention mlflow-go (#1496)

* Attempt to add multiarch digest (#1495)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Geoffrey Wilson <geoff@gr-oss.io>
Co-authored-by: Florian Verdonck <florian.verdonck@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavlovic-ivan pavlovic-ivan pavlovic-ivan approved these changes

@jgiannuzzi jgiannuzzi jgiannuzzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nojaf @jgiannuzzi @pavlovic-ivan