Fixed Screens to adjust to mobile views #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
its-edmund
reviewed
Sep 13, 2022
| const locationPage = () => { | ||
| if (isPageMobile) { | ||
| return ( | ||
| <ParallaxComponent pageIndex={pageIndex} transitionTime={1500} transitionDelay={0} styles={{ height: '100vh' }}> |
There was a problem hiding this comment.
There was a problem hiding this comment.
Hey Edmund, getting the location pointer will be a bit of challenge so currently it just uses an arrow on the image to point to the location as shown below.
|
After that, LGTM. If you need help with package-lock conflict, lmk |
its-edmund
approved these changes
Nov 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number(s): #100
This addresses the ticket number listed above.
What does this PR change and why?
Changes three of the screens on WheelRight to be mobile fluid that match the mobile design on figma. Only conflict with figma on desktop and mobile was the straight lines that pointed to the location on the map. Instead of doing that, just used a picture with an arrow already pointed to the location.
Checklist
develop)Critical Changes
None. Just styling.
Related PRs
How to Test
Open up in browser and use the dev tools to try styling on different screen sizes.