Feature/optimisations for header value builders #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved some usings out to global usings; BREAKING CHANGE: Removed the ability to remove the "X-Powered-By" header;
…aultContentSecurityPolicy)
…: each job is a separate container instance
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this PR
This PR brings in a lot of small changes and one breaking change.
BREAKING CHANGE: The functionality to remove the X-Powered-By header has now been removed from the code base. Even though this is an HTTP header recommended in the OWASP Secure Headers project, it is not something that ASP .NET Core can control as it is set at the reverse proxy level. Please see Server Header: A Warning for more detail.
The small changes provided in this PR are around code clean up (moving common using statements out to
global.usings.csfiles, tidying up line lengths, fixing typos, etc.) and a few tiny optimisations when building the final header values. It also includes a few extra unit tests and a minor version bump (along with updates to the relevant files).