Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header Caching #152

Merged
merged 3 commits into from
Dec 26, 2024
Merged

Header Caching #152

merged 3 commits into from
Dec 26, 2024

Conversation

GaProgMan
Copy link
Owner

@GaProgMan GaProgMan commented Dec 26, 2024

Rationale for this PR

This PR adds support for caching the calculated header values.

Each time that the middleware is called (on every request-response cycle), the following happens:

PR Checklist

Feel free to either check the following items (by place an x inside of the square brackets) or by replacing the square brackets with a relevant emoji from the following list:

  • ✅ to indicate that you have checked something off
  • ❎ to indicate that you haven't checked something off
  • ❓ to indicate that something might not be relevant (writing tests for documentation changes, for instance)

Essential

These items are essential and must be completed for each commit. If they are not completed, the PR may not be accepted.

  • [ ❓ ] I have added tests to the OwaspHeaders.Core.Tests project
  • [ ✅ ] I have run the dotnet-format command and fixed any .editorconfig issues
  • [ ✅ ] I have ensured that the code coverage has not dropped below 65%
  • [ ✅ ] I have increased the version number in OwaspHeaders.Core.csproj (only relevant for code changes)

Optional

  • [ ❓ ] I have documented the new feature in the docs directory
  • [ ❓ ] I have provided a code sample, showing how someone could use the new code

Any Other Information

This section is optional, but it might be useful to list any other information you think is relevant.

Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
OwaspHeaders.Core 87% 74% 281
OwaspHeaders.Core 87% 74% 281
Summary 87% (1142 / 1312) 74% (272 / 368) 562

@GaProgMan GaProgMan merged commit 43fadbd into main Dec 26, 2024
6 checks passed
@GaProgMan GaProgMan deleted the feature/header-caching branch December 26, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants