Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/typos #157

Merged
merged 4 commits into from
Dec 27, 2024
Merged

Bugfix/typos #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c54b5c0
Fixed errant semicolon in values for X-Permitted-Cross-Domain-Policies
jamie-taylor-rjj Dec 27, 2024
7dbc502
X-Frame-Options values are no longer all caps
jamie-taylor-rjj Dec 27, 2024
3b50ef4
Fixed tests
jamie-taylor-rjj Dec 27, 2024
9f638a1
Merge branch 'main' into bugfix/typos
jamie-taylor-rjj Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Models/PermittedCrossDomainPolicyConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@ public string BuildHeaderValue()
switch (XPermittedCrossDomainOptionValue)
{
case XPermittedCrossDomainOptionValue.none:
return "none;";
return "none";
case XPermittedCrossDomainOptionValue.masterOnly:
return "master-only;";
return "master-only";
case XPermittedCrossDomainOptionValue.byContentType:
return "by-content-type;";
return "by-content-type";
case XPermittedCrossDomainOptionValue.byFtpFileType:
return "by-ftp-file-type;";
return "by-ftp-file-type";
case XPermittedCrossDomainOptionValue.all:
return "all;";
return "all";
default:
ArgumentExceptionHelper.RaiseException(nameof(XPermittedCrossDomainOptionValue));
break;
Expand Down
8 changes: 4 additions & 4 deletions src/Models/XFrameOptionsConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,14 @@ public string BuildHeaderValue()
switch (OptionValue)
{
case XFrameOptions.Deny:
return "DENY";
return "deny";
case XFrameOptions.Sameorigin:
return "SAMEORIGIN";
return "sameorigin";
case XFrameOptions.Allowfrom:
HeaderValueGuardClauses.StringCannotBeNullOrWhitsSpace(AllowFromDomain, nameof(AllowFromDomain));
return $"ALLOW-FROM({AllowFromDomain})";
return $"allow-from: ({AllowFromDomain})";
case XFrameOptions.AllowAll:
return "ALLOWALL";
return "allowall";
}
// We should never hit this return statement. It is included here
// as the method NEEDs to return something.
Expand Down
4 changes: 2 additions & 2 deletions tests/OwaspHeaders.Core.Tests/CustomHeaders/DefaultSecureHeadersIntegrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public async Task AllHeaders_Present_When_BuildDefault_Used()

Assert.True(headerPresentConfig.UseXFrameOptions);
Assert.Contains(context.Response.Headers, h => h.Key == Constants.XFrameOptionsHeaderName);
Assert.Equal("DENY", context.Response.Headers[Constants.XFrameOptionsHeaderName]);
Assert.Equal("deny", context.Response.Headers[Constants.XFrameOptionsHeaderName]);

Assert.True(headerPresentConfig.UseXssProtection);
Assert.Contains(context.Response.Headers, h => h.Key == Constants.XssProtectionHeaderName);
Expand All @@ -44,7 +44,7 @@ public async Task AllHeaders_Present_When_BuildDefault_Used()

Assert.True(headerPresentConfig.UsePermittedCrossDomainPolicy);
Assert.Contains(context.Response.Headers, h => h.Key == Constants.PermittedCrossDomainPoliciesHeaderName);
Assert.Equal("none;", context.Response.Headers[Constants.PermittedCrossDomainPoliciesHeaderName]);
Assert.Equal("none", context.Response.Headers[Constants.PermittedCrossDomainPoliciesHeaderName]);

Assert.True(headerPresentConfig.UseReferrerPolicy);
Assert.Contains(context.Response.Headers, h => h.Key == Constants.ReferrerPolicyHeaderName);
Expand Down
4 changes: 2 additions & 2 deletions ...pHeaders.Core.Tests/SecureHeadersMiddlewareExtensionTests/SecureHeadersMiddlewareTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ private void AssertHeadersInResponse(SecureHeadersMiddlewareConfiguration middle

// X-Frame-Options
Assert.True(middlewareConfiguration.UseXFrameOptions);
Assert.Equal("DENY", middlewareConfiguration.XFrameOptionsConfiguration.BuildHeaderValue());
Assert.Equal("deny", middlewareConfiguration.XFrameOptionsConfiguration.BuildHeaderValue());

// X-Content-Type-Options
Assert.True(middlewareConfiguration.UseXContentTypeOptions);
Expand All @@ -116,7 +116,7 @@ private void AssertHeadersInResponse(SecureHeadersMiddlewareConfiguration middle

// X-Permitted-Cross-Domain-Policies
Assert.True(middlewareConfiguration.UsePermittedCrossDomainPolicy);
Assert.Equal("none;", middlewareConfiguration.PermittedCrossDomainPolicyConfiguration.BuildHeaderValue());
Assert.Equal("none", middlewareConfiguration.PermittedCrossDomainPolicyConfiguration.BuildHeaderValue());

// Referrer-Policy
Assert.True(middlewareConfiguration.UseReferrerPolicy);
Expand Down
Loading