fix: tests

GalloDaSballo · Jul 7, 2022 · 48eeea6 · 48eeea6
1 parent 0195379
commit 48eeea6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/contracts/OnChainPricingMainnet.sol b/contracts/OnChainPricingMainnet.sol
@@ -69,7 +69,7 @@ contract OnChainPricingMainnet {
             quotes[4] = Quote("uniV3WithWETH", univ3WithWETHQuote);		
         }
 
-        /// TODO: Add Balancer
+        /// NOTE: Balancer is in V2
 
 
         // Because this is a generalized contract, it is best to just loop,

diff --git a/tests/aura_processor/test_sell_bribes_weth_aura.py b/tests/aura_processor/test_sell_bribes_weth_aura.py
@@ -36,6 +36,7 @@ def test_sell_bribes_for_weth_cant_sell_aura(setup_aura_processor, weth, manager
 
 
 def test_sell_bribes_for_weth_works_when_selling_usdc_for_weth(setup_aura_processor, usdc, weth, manager, settlement):
+  ## NOTE: Because of UniV3 this may be detected as a revert, run the test separately and it should pass
   sell_amount = 1000000000
 
   order_details = get_cowswap_order(setup_aura_processor, usdc, weth, sell_amount)

diff --git a/tests/on_chain_pricer.py/test_univ3_pricer.py b/tests/on_chain_pricer.py/test_univ3_pricer.py
@@ -10,8 +10,8 @@ def test_get_univ3_price(oneE18, weth, usdc, pricer):
   ## 1e18
   sell_amount = 1 * oneE18
 
-  ## minimum quote for ETH in USDC(1e6)
-  p = 1 * 1500 * 1000000  
+  ## minimum quote for ETH in USDC(1e6) ## Update based on market conditions
+  p = 1 * 1150 * 1000000  
   quote = pricer.getUniV3Price.call(weth.address, sell_amount, usdc.address) 
   assert quote >= p