applet.control.servo: modify to use port groups #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
reviewed
Jul 23, 2024
whitequark
reviewed
Jul 23, 2024
whitequark
reviewed
Jul 23, 2024
|
This PR breaks tests (you need to remove the first Once you do that, please squash the commits (you can use the "fixup" rebase command to discard their useless messages) and we're good to go! |
isabelburgos
force-pushed
the
isabelburgos/servo-padless
branch
2 times, most recently
from
7e2f129 to
e138345
Compare
|
Your commit message actually ended up having some unrelated junk in it. Although not a huge issue in this case, we try to keep the git history readable and free of autogenerated noise that can end up in it if you use e.g. GitHub's web interface. Could you remove it please? |
isabelburgos
force-pushed
the
isabelburgos/servo-padless
branch
from
e138345 to
a7a43cb
Compare
|
Thanks for all the updates! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #599.
This one seems straightforward. I tested that it builds for revC3 with no errors, with and without a
--pin-outargument.