Changes to make queryPath optional #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chitara-01
requested changes
Oct 10, 2023
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
============================================
- Coverage 12.45% 12.43% -0.03%
Complexity 63 63
============================================
Files 53 53
Lines 2480 2484 +4
Branches 207 208 +1
============================================
Hits 309 309
- Misses 2152 2156 +4
Partials 19 19
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Goutam1511
reviewed
Oct 11, 2023
| .usingStandardSql() | ||
| .withMethod(Method.DEFAULT)) | ||
| .apply("AddTableNameAsKey", WithKeys.of(tableRef())); | ||
| throw new IllegalArgumentException("Export method not supported"); |
There was a problem hiding this comment.
May not be the intended behaviour but since the EXPORT case used to work with DEFAULT read earlier, are we declaring that somewhere before removing the support altogether?
Goutam1511
reviewed
Oct 11, 2023
src/main/java/com/google/swarm/tokenization/common/BigQueryReadTransform.java
Show resolved
Hide resolved
Goutam1511
reviewed
Oct 11, 2023
| .withMethod(Method.DEFAULT)) | ||
| .apply("AddTableNameAsKey", WithKeys.of(tableRef())); | ||
| } | ||
|
|
||
| case EXPORT: |
There was a problem hiding this comment.
Can we just club EXPORT and DIRECT_READ together and throw the exception "Only DEFAULT Read Method supported"?
case EXPORT: case DIRECT_READ: throw new IllegalArgumentException("Only DEFAULT READ method supported");
Goutam1511
reviewed
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (Short summary of what is being done) :
Simplify REID workflow by making the query parameter optionalDescription (Describe in detail the fix made) :
The REID workflow required users to compulsarily provide SQL query to read from the BigQuery. This involved manual steps to create a GCS object containing sql query and passing its path in the pipeline parameter. With this change, the queryPath parameter has been made optional and users can run REID pipeline without needing to provide a SQL query.Bug ID (if any) :
b/293427326Public Documentation (if any) :
TESTED (Test Cases with scenario and description - must have 1 positive and 1 negative scenario) :