Break TaskConstructor out of base Issue class. #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for stabilizing the base classes (GothenburgBitFactory#791), I'm moving these methods which child classes never need to call to a separate class in the collect module. We *could* leave them where they are and just make them private methods, but at this point I think slimming down the base classes as much as possible is our best bet to being disciplined about their stabilization. This not only removes lines of code but I believe the entire class of would-be private methods. I also removed the __str__ and __repr__ methods, which depended on the get_taskwarrior_record method. These used to be used in logging messages in db.synchronize but since GothenburgBitFactory#1037 db.synchronize is receiving dict's and not Issue's. (The usages in that method are presently mixed between logging `issue` and logging `issue['description']`. The logs could be improved by switching the remainder to the latter.)
ryneeverett
force-pushed
the
extract-taskconstructor
branch
from
6d15698 to
8fb61d5
Compare
ryneeverett
merged commit 2a041f4
into
GothenburgBitFactory:develop
36 of 37 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for stabilizing the base classes (#791), I'm moving these methods which child classes never need to call to a separate class in the collect module.
We could leave them where they are and just make them private methods, but at this point I think slimming down the base classes as much as possible is our best bet to being disciplined about their stabilization. This not only removes lines of code but I believe the entire class of would-be private methods.
I also removed the str and repr methods, which depended on the get_taskwarrior_record method. These used to be used in logging messages in db.synchronize but since #1037 db.synchronize is receiving dict's and not Issue's. (The usages in that method are presently mixed between logging
issueand loggingissue['description']. The logs could be improved by switching the remainder to the latter.)