-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ExecutingInvocationUnit to use customizable executors #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
base/src/main/java/proguard/evaluation/executor/MethodExecutionInfo.java
Outdated
Show resolved
Hide resolved
base/src/main/java/proguard/evaluation/ExecutingInvocationUnit.java
Outdated
Show resolved
Hide resolved
This bug was revealed by checking that length of the parameter list matches the method descriptor in ReflectionExecutor
Looks good to me, I would just add a changelog entry for stuff you have fixed and other functional changes (e.g., the value analysis fix for category 2 values, the array support to handle String.format and similar methods) |
mrjameshamilton
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the old
ExecutingInvocationUnit
and sensibly separates its responsibilities into other classes.It now maintains a configurable list of executors, each of which provides a way to obtain the result of a method within a range of supported methods.
A major advantage of this approach is that executors can handle a method however they want, e.g., avoiding reflection.
The old behavior is kept as a default, meaning a
StringReflectionExecutor
will be added unless explicitly disabled.Aside from simplifying major parts of the logic, some improvements to the functionality have been made:
String.join()
andString.format()
).ExecutingInvocationUnit
makes sure that the instance of the method in stack and variables will always be updated if it changed.