feat(command): scheduler:export #198
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Guikingone
commented
Oct 14, 2021
•
Guikingone
commented
| Q | A |
|---|---|
| PHP version? | 8.0 |
| Bundle version? | >= 0.9.0 |
| Symfony version? | >= 5.4 |
| New feature? | yes |
| Bug fix? | yes |
babeuloula
suggested changes
Mar 3, 2022
Comment on lines
+29
to
+33
| ExporterRegistryInterface $exporterRegistry, | ||
| SchedulerInterface $scheduler | ||
| ) { | ||
| $this->exporterRegistry = $exporterRegistry; | ||
| $this->scheduler = $scheduler; |
There was a problem hiding this comment.
Suggested change
| ExporterRegistryInterface $exporterRegistry, | |
| SchedulerInterface $scheduler | |
| ) { | |
| $this->exporterRegistry = $exporterRegistry; | |
| $this->scheduler = $scheduler; | |
| private ExporterRegistryInterface $exporterRegistry, | |
| private SchedulerInterface $scheduler | |
| ) { |
Comment on lines
+23
to
+24
| private ExporterRegistryInterface $exporterRegistry; | ||
| private SchedulerInterface $scheduler; |
There was a problem hiding this comment.
Suggested change
| private ExporterRegistryInterface $exporterRegistry; | |
| private SchedulerInterface $scheduler; |
| */ | ||
| abstract class AbstractExporter implements ExporterInterface | ||
| { | ||
| private string $projectDir; |
There was a problem hiding this comment.
Suggested change
| private string $projectDir; |
Comment on lines
+14
to
+17
| public function __construct(string $projectDir) | ||
| { | ||
| $this->projectDir = $projectDir; | ||
| } |
There was a problem hiding this comment.
Suggested change
| public function __construct(string $projectDir) | |
| { | |
| $this->projectDir = $projectDir; | |
| } | |
| public function __construct(private string $projectDir) | |
| { | |
| } |
Comment on lines
+20
to
+23
| /** | ||
| * @var ExporterInterface[] | ||
| */ | ||
| private iterable $exporterList; |
There was a problem hiding this comment.
Suggested change
| /** | |
| * @var ExporterInterface[] | |
| */ | |
| private iterable $exporterList; |
Comment on lines
+28
to
+31
| public function __construct(iterable $exporterList) | ||
| { | ||
| $this->exporterList = $exporterList; | ||
| } |
There was a problem hiding this comment.
Suggested change
| public function __construct(iterable $exporterList) | |
| { | |
| $this->exporterList = $exporterList; | |
| } | |
| public function __construct(private iterable $exporterList) | |
| { | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.