Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(configuration) : tasks node validation #85

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(configuration) : tasks node validation #85

wants to merge 5 commits into from

Conversation

jvancoillie
Copy link
Contributor

Q A
PHP version? 7.4
Bundle version? 0.4.2
New feature? yes
Bug fix? no
Discussion? # ...

Improve the validation of the configuration.

I would like to implement validation on the definition of tasks in the application.
Before going further, I realized that it was possible to simplify the configuration of subtasks while keeping the same operation as the basic tasks.

I don't want to upset your plans and I don't know if I'm doing the right thing by proposing this PR but I find this bundle very useful and I'm happy to be able to give a hand.

If you think it's derogatory, don't hesitate to let me know.

@Guikingone
Copy link
Owner

Hi @jvancoillie 👋🏻

No problem for working on this, feel free to work, submit and open discussions, this bundle is also a community one 🙂

@jvancoillie jvancoillie changed the title feat(configuration) : tasks node validation WIP feat(configuration) : tasks node validation Apr 30, 2021
@jvancoillie
Copy link
Contributor Author

I proposed a validation on the configuration. I have trouble seeing how to set up a recursive on the subtasks. did you take a look? any remarks or suggestion?

@Guikingone
Copy link
Owner

I'm gonna review it tonight or tomorrow 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants