Merge pull request #1705 from HedvigInsurance/feature/payments/update…

…-tests Update payment tests
HedvigInsurance · Jan 30, 2025 · 5a99a3b · 5a99a3b
2 parents b5195aa + a82e0ff
commit 5a99a3b
Show file tree

Hide file tree

Showing 3 changed files with 103 additions and 43 deletions.
diff --git a/Projects/Payment/Tests/PaymentMockData.swift b/Projects/Payment/Tests/PaymentMockData.swift
@@ -8,20 +8,39 @@ import hCore
 struct MockPaymentData {
     @discardableResult static func createMockPaymentService(
         fetchPaymentData: @escaping FetchPaymentData = {
-            .init(
-                id: "id",
-                payment: .init(
-                    gross: .init(amount: "230", currency: "SEK"),
-                    net: .init(amount: "230", currency: "SEK"),
-                    carriedAdjustment: .init(amount: "230", currency: "SEK"),
-                    settlementAdjustment: nil,
-                    date: .init()
+            (
+                upcoming: .init(
+                    id: "id1",
+                    payment: .init(
+                        gross: .init(amount: "230", currency: "SEK"),
+                        net: .init(amount: "230", currency: "SEK"),
+                        carriedAdjustment: .init(amount: "230", currency: "SEK"),
+                        settlementAdjustment: nil,
+                        date: .init()
+                    ),
+                    status: .upcoming,
+                    contracts: [],
+                    discounts: [],
+                    paymentDetails: nil,
+                    addedToThePayment: nil
                 ),
-                status: .success,
-                contracts: [],
-                discounts: [],
-                paymentDetails: nil,
-                addedToThePayment: nil
+                ongoing: [
+                    .init(
+                        id: "id2",
+                        payment: .init(
+                            gross: .init(amount: "230", currency: "SEK"),
+                            net: .init(amount: "230", currency: "SEK"),
+                            carriedAdjustment: .init(amount: "230", currency: "SEK"),
+                            settlementAdjustment: nil,
+                            date: .init()
+                        ),
+                        status: .pending,
+                        contracts: [],
+                        discounts: [],
+                        paymentDetails: nil,
+                        addedToThePayment: nil
+                    )
+                ]
             )
         },
         fetchPaymentStatusData: @escaping FetchPaymentStatusData = {
@@ -60,7 +79,7 @@ struct MockPaymentData {
     }
 }
 
-typealias FetchPaymentData = () async throws -> PaymentData?
+typealias FetchPaymentData = () async throws -> (upcoming: Payment.PaymentData?, ongoing: [Payment.PaymentData])
 typealias FetchPaymentStatusData = () async throws -> PaymentStatusData
 typealias FetchPaymentDiscountsData = () async throws -> PaymentDiscountsData
 typealias FetchPaymentHistoryData = () async throws -> [PaymentHistoryListData]
@@ -97,7 +116,7 @@ class MockPaymentService: hPaymentClient {
         self.fetchConnectPaymentUrl = fetchConnectPaymentUrl
     }
 
-    func getPaymentData() async throws -> PaymentData? {
+    func getPaymentData() async throws -> (upcoming: Payment.PaymentData?, ongoing: [Payment.PaymentData]) {
         events.append(.getPaymentData)
         let data = try await fetchPaymentData()
         return data

diff --git a/Projects/Payment/Tests/ServiceTests/PaymentServiceTests.swift b/Projects/Payment/Tests/ServiceTests/PaymentServiceTests.swift
@@ -19,20 +19,39 @@ final class PaymentServiceTests: XCTestCase {
     }
 
     func testFetchPaymentDataSuccess() async {
-        let paymentData: PaymentData = .init(
-            id: "id",
-            payment: .init(
-                gross: .init(amount: "230", currency: "SEK"),
-                net: .init(amount: "230", currency: "SEK"),
-                carriedAdjustment: .init(amount: "230", currency: "SEK"),
-                settlementAdjustment: nil,
-                date: .init()
+        let paymentData: (upcoming: Payment.PaymentData?, ongoing: [Payment.PaymentData]) = (
+            upcoming: .init(
+                id: "id1",
+                payment: .init(
+                    gross: .init(amount: "230", currency: "SEK"),
+                    net: .init(amount: "230", currency: "SEK"),
+                    carriedAdjustment: .init(amount: "230", currency: "SEK"),
+                    settlementAdjustment: nil,
+                    date: .init()
+                ),
+                status: .upcoming,
+                contracts: [],
+                discounts: [],
+                paymentDetails: nil,
+                addedToThePayment: nil
             ),
-            status: .success,
-            contracts: [],
-            discounts: [],
-            paymentDetails: nil,
-            addedToThePayment: nil
+            ongoing: [
+                .init(
+                    id: "id2",
+                    payment: .init(
+                        gross: .init(amount: "230", currency: "SEK"),
+                        net: .init(amount: "230", currency: "SEK"),
+                        carriedAdjustment: .init(amount: "230", currency: "SEK"),
+                        settlementAdjustment: nil,
+                        date: .init()
+                    ),
+                    status: .pending,
+                    contracts: [],
+                    discounts: [],
+                    paymentDetails: nil,
+                    addedToThePayment: nil
+                )
+            ]
         )
 
         let mockService = MockPaymentData.createMockPaymentService(
@@ -41,7 +60,8 @@ final class PaymentServiceTests: XCTestCase {
         self.sut = mockService
 
         let respondedPaymentData = try! await mockService.getPaymentData()
-        assert(respondedPaymentData == paymentData)
+        assert(respondedPaymentData.ongoing == paymentData.ongoing)
+        assert(respondedPaymentData.upcoming == paymentData.upcoming)
     }
 
     func testFetchPaymentStatusDataSuccess() async {

diff --git a/Projects/Payment/Tests/StoreTests/StoreLoadTests.swift b/Projects/Payment/Tests/StoreTests/StoreLoadTests.swift
@@ -18,20 +18,39 @@ final class StoreLoadTests: XCTestCase {
     }
 
     func testLoadPaymentDataSuccess() async throws {
-        let paymentData: PaymentData = .init(
-            id: "id",
-            payment: .init(
-                gross: .init(amount: "230", currency: "SEK"),
-                net: .init(amount: "230", currency: "SEK"),
-                carriedAdjustment: .init(amount: "230", currency: "SEK"),
-                settlementAdjustment: nil,
-                date: .init()
+        let paymentData: (upcoming: Payment.PaymentData?, ongoing: [Payment.PaymentData]) = (
+            upcoming: .init(
+                id: "id1",
+                payment: .init(
+                    gross: .init(amount: "230", currency: "SEK"),
+                    net: .init(amount: "230", currency: "SEK"),
+                    carriedAdjustment: .init(amount: "230", currency: "SEK"),
+                    settlementAdjustment: nil,
+                    date: .init()
+                ),
+                status: .upcoming,
+                contracts: [],
+                discounts: [],
+                paymentDetails: nil,
+                addedToThePayment: nil
             ),
-            status: .success,
-            contracts: [],
-            discounts: [],
-            paymentDetails: nil,
-            addedToThePayment: nil
+            ongoing: [
+                .init(
+                    id: "id2",
+                    payment: .init(
+                        gross: .init(amount: "230", currency: "SEK"),
+                        net: .init(amount: "230", currency: "SEK"),
+                        carriedAdjustment: .init(amount: "230", currency: "SEK"),
+                        settlementAdjustment: nil,
+                        date: .init()
+                    ),
+                    status: .pending,
+                    contracts: [],
+                    discounts: [],
+                    paymentDetails: nil,
+                    addedToThePayment: nil
+                )
+            ]
         )
 
         let mockService = MockPaymentData.createMockPaymentService(
@@ -42,7 +61,8 @@ final class StoreLoadTests: XCTestCase {
         await store.sendAsync(.load)
         try await Task.sleep(nanoseconds: 100_000_000)
         XCTAssertNil(store.loadingState[.getPaymentData])
-        assert(store.state.paymentData == paymentData)
+        assert(store.state.ongoingPaymentData == paymentData.ongoing)
+        assert(store.state.paymentData == paymentData.upcoming)
         assert(mockService.events.count == 1)
         assert(mockService.events.first == .getPaymentData)
     }
@@ -56,6 +76,7 @@ final class StoreLoadTests: XCTestCase {
         await store.sendAsync(.load)
         XCTAssertNotNil(store.loadingState[.getPaymentData])
         assert(store.state.paymentData == nil)
+        assert(store.state.ongoingPaymentData.isEmpty)
         assert(mockService.events.count == 1)
         assert(mockService.events.first == .getPaymentData)
     }