Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update form - remove hCoreUI hForm #1690

Merged
merged 10 commits into from
Jan 23, 2025
Merged

Conversation

sladan-hedvig
Copy link
Contributor

[APP-XXX]

  • Removed hCoreUI hForm

Checklist

  • Dark/light mode verification
  • Landscape verification
  • iPad verification
  • iPod/iPhone 12 mini/iPhone SE verification

@sladan-hedvig sladan-hedvig changed the base branch from main to fix/form-update January 23, 2025 14:47
@sladan-hedvig sladan-hedvig marked this pull request as ready for review January 23, 2025 14:47
@sladan-hedvig sladan-hedvig requested a review from a team as a code owner January 23, 2025 14:47
@sladan-hedvig
Copy link
Contributor Author

sladan-hedvig commented Jan 23, 2025

I have checked every view that is using hCoreUI view that is affected by this change and fixed it where I encounter the issue

withAnimation {
self.intent = data
}
// let data = try await service.sendIntent(contractId: contractId, coInsured: coInsured)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's up with this? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed meanwhile xD was testing something

@sladan-hedvig sladan-hedvig merged commit bb71c39 into fix/form-update Jan 23, 2025
@sladan-hedvig sladan-hedvig deleted the fix/form-update-hCore branch January 23, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants