Skip to content
This repository has been archived by the owner on Dec 23, 2024. It is now read-only.

Fix DATA-DOG/go-sqlmock dependency #68

Merged
merged 1 commit into from
Sep 26, 2019

Conversation

unguiculus
Copy link
Contributor

Running go mod tidy results in the following error:

go mod tidy
go: finding gopkg.in/DATA-DOG/go-sqlmock.v1 v1.3.3
github.com/myuser/myapp/pkg/health imports
	github.com/InVisionApp/go-health/checkers tested by
	github.com/InVisionApp/go-health/checkers.test imports
	gopkg.in/DATA-DOG/go-sqlmock.v1: cannot find module providing package gopkg.in/DATA-DOG/go-sqlmock.v1

This PR should fix the dependency.

See also for further reference:

@rhoetsc
Copy link

rhoetsc commented Sep 26, 2019

@schigh Can you have a look, please.

@schigh
Copy link
Contributor

schigh commented Sep 26, 2019

Yessir. Apologies for not seeing these alerts sooner!

@schigh schigh self-requested a review September 26, 2019 14:10
Copy link
Contributor

@schigh schigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM 🌮 🌮 🌮 🌮 🌮

@schigh schigh merged commit 506fef8 into InVisionApp:master Sep 26, 2019
@schigh
Copy link
Contributor

schigh commented Sep 26, 2019

@unguiculus @rhoetsc I am following this up by moving this entire repo to modules very soon (today-ish)

@unguiculus unguiculus deleted the fix-sqlmock-dependency branch September 27, 2019 07:16
@unguiculus
Copy link
Contributor Author

@schigh Thanks for getting this in so quickly. 🎉

I had to fix the module migration, though. See #70 and #71.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants