Skip to content

Commit

Permalink
Merge pull request #79 from dfm/joss-edits
Browse files Browse the repository at this point in the history
Edit for JOSS review
  • Loading branch information
Jammy2211 authored May 28, 2024
2 parents ee486bd + c4c4ce9 commit b434b75
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions paper/paper.bib
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ @article{astropy1
Doi = {10.1051/0004-6361/201322068},
Eid = {A33},
Eprint = {1307.6212},
Journal = {\aap},
Journal = {A\&A},
Keywords = {methods: data analysis, methods: miscellaneous, virtual observatory tools},
Month = oct,
Pages = {A33},
Expand All @@ -21,7 +21,7 @@ @article{astropy2
Author = {{Price-Whelan}, A.~M. and {Sip{\H{o}}cz}, B.~M. and {G{\"u}nther}, H.~M. and {Lim}, P.~L. and {Crawford}, S.~M. and {Conseil}, S. and {Shupe}, D.~L. and {Craig}, M.~W. and {Dencheva}, N. and {Ginsburg}, A. and {VanderPlas}, J.~T. and {Bradley}, L.~D. and {P{\'e}rez-Su{\'a}rez}, D. and {de Val-Borro}, M. and {Paper Contributors}, (Primary and {Aldcroft}, T.~L. and {Cruz}, K.~L. and {Robitaille}, T.~P. and {Tollerud}, E.~J. and {Coordination Committee}, (Astropy and {Ardelean}, C. and {Babej}, T. and {Bach}, Y.~P. and {Bachetti}, M. and {Bakanov}, A.~V. and {Bamford}, S.~P. and {Barentsen}, G. and {Barmby}, P. and {Baumbach}, A. and {Berry}, K.~L. and {Biscani}, F. and {Boquien}, M. and {Bostroem}, K.~A. and {Bouma}, L.~G. and {Brammer}, G.~B. and {Bray}, E.~M. and {Breytenbach}, H. and {Buddelmeijer}, H. and {Burke}, D.~J. and {Calderone}, G. and {Cano Rodr{\'\i}guez}, J.~L. and {Cara}, M. and {Cardoso}, J.~V.~M. and {Cheedella}, S. and {Copin}, Y. and {Corrales}, L. and {Crichton}, D. and {D{\textquoteright}Avella}, D. and {Deil}, C. and {Depagne}, {\'E}. and {Dietrich}, J.~P. and {Donath}, A. and {Droettboom}, M. and {Earl}, N. and {Erben}, T. and {Fabbro}, S. and {Ferreira}, L.~A. and {Finethy}, T. and {Fox}, R.~T. and {Garrison}, L.~H. and {Gibbons}, S.~L.~J. and {Goldstein}, D.~A. and {Gommers}, R. and {Greco}, J.~P. and {Greenfield}, P. and {Groener}, A.~M. and {Grollier}, F. and {Hagen}, A. and {Hirst}, P. and {Homeier}, D. and {Horton}, A.~J. and {Hosseinzadeh}, G. and {Hu}, L. and {Hunkeler}, J.~S. and {Ivezi{\'c}}, {\v{Z}}. and {Jain}, A. and {Jenness}, T. and {Kanarek}, G. and {Kendrew}, S. and {Kern}, N.~S. and {Kerzendorf}, W.~E. and {Khvalko}, A. and {King}, J. and {Kirkby}, D. and {Kulkarni}, A.~M. and {Kumar}, A. and {Lee}, A. and {Lenz}, D. and {Littlefair}, S.~P. and {Ma}, Z. and {Macleod}, D.~M. and {Mastropietro}, M. and {McCully}, C. and {Montagnac}, S. and {Morris}, B.~M. and {Mueller}, M. and {Mumford}, S.~J. and {Muna}, D. and {Murphy}, N.~A. and {Nelson}, S. and {Nguyen}, G.~H. and {Ninan}, J.~P. and {N{\"o}the}, M. and {Ogaz}, S. and {Oh}, S. and {Parejko}, J.~K. and {Parley}, N. and {Pascual}, S. and {Patil}, R. and {Patil}, A.~A. and {Plunkett}, A.~L. and {Prochaska}, J.~X. and {Rastogi}, T. and {Reddy Janga}, V. and {Sabater}, J. and {Sakurikar}, P. and {Seifert}, M. and {Sherbert}, L.~E. and {Sherwood-Taylor}, H. and {Shih}, A.~Y. and {Sick}, J. and {Silbiger}, M.~T. and {Singanamalla}, S. and {Singer}, L.~P. and {Sladen}, P.~H. and {Sooley}, K.~A. and {Sornarajah}, S. and {Streicher}, O. and {Teuben}, P. and {Thomas}, S.~W. and {Tremblay}, G.~R. and {Turner}, J.~E.~H. and {Terr{\'o}n}, V. and {van Kerkwijk}, M.~H. and {de la Vega}, A. and {Watkins}, L.~L. and {Weaver}, B.~A. and {Whitmore}, J.~B. and {Woillez}, J. and {Zabalza}, V. and {Contributors}, (Astropy},
Doi = {10.3847/1538-3881/aabc4f},
Eid = {123},
Journal = {\aj},
Journal = {AJ},
Keywords = {methods: data analysis, methods: miscellaneous, methods: statistical, reference systems, Astrophysics - Instrumentation and Methods for Astrophysics},
Month = Sep,
Pages = {123},
Expand Down Expand Up @@ -652,7 +652,7 @@ @article{Halverson2016
@ARTICLE{Bellini2013,
author = {{Bellini}, A. and {van der Marel}, R.~P. and {Anderson}, J.},
title = "{HST proper motions of stars within globular clusters.}",
journal = {\memsai},
journal = {Mem. Societa Astronomica Italiana},
keywords = {Astrometry: proper motions, Stars: Population II, Galaxy: globular clusters, Astrophysics - Solar and Stellar Astrophysics, Astrophysics - Galaxy Astrophysics},
year = 2013,
month = jan,
Expand Down Expand Up @@ -711,7 +711,7 @@ @INPROCEEDINGS{cdm03
@article{Anderson2010,
author = {{Anderson}, Jay and {Bedin}, Luigi R.},
title = "{An Empirical Pixel-Based Correction for Imperfect CTE. I. HST{\textquoteright}s Advanced Camera for Surveys}",
journal = {\pasp},
journal = {PASP},
keywords = {Astrophysics - Instrumentation and Methods for Astrophysics},
year = 2010,
month = sep,
Expand Down
8 changes: 4 additions & 4 deletions paper/paper.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ the faint spectra of the first galaxies in the Universe [@Dunlop2013; @Bouwens20
galaxy shapes due to gravitational lensing [@Massey2007; @Schrabback2010] and a high precision map of stars within
the Milky Way [@Brown2018; @Brown2020]. These observations require a deep understanding of the telescope's
instrumental characteristics, including the calibration and correction of charge transfer inefficiency
(hereafter CTI) [@Massey2010d; @Massey2014], a phenomena where radiation damage to the telescope's charge-coupled
[hereafter CTI, @Massey2010d; @Massey2014], a phenomenon where radiation damage to the telescope's charge-coupled
device (CCD) sensors leads to gradually increased smearing in acquired exposures over the telescope's lifetime.

`PyAutoCTI` is an open-source Python 3.8 - 3.11 [@python] package for the calibration of CTI for space telescopes. By interfacing
Expand All @@ -49,7 +49,7 @@ for building a temporal model of CTI over the telescope's lifetime. The software
including support for graphical models that simultaneously fits large CTI calibration datasets and an SQLite3
database that allows extensive suites of calibration results to be loaded, queried and analysed.
Accompanying `PyAutoCTI` is the [autocti workspace](https://github.com/Jammy2211/autocti_workspace), which includes
example scripts, datasets and an overview of core `PyAutoCTI` functionality. Readers can checkout
example scripts, datasets and an overview of core `PyAutoCTI` functionality. Readers can check out
the [readthedocs](https://pyautocti.readthedocs.io/en/latest/) for a complete overview of `PyAutoCTI`'s
features.

Expand All @@ -66,7 +66,7 @@ If this time is longer than the time taken to move a cloud of electrons to the n
released back into its original charge cloud, but to a subsequent one: creating a characteristic 'trailing' or 'smearing'
effect behind sources in the image. The CTI properties of a CCD can be calibrated, using image data that has sharp edges
whose position and flux are known (or can be determined) prior to readout. `PyAutoCTI` fits a CTI model to these sharp
edges and their preceeding trails which form due to CTI.
edges and their preceding trails which form due to CTI.

![A typical, raw HST ACS / WFC image, in units of electrons. This 30" x 15" (600 x 300 pixels) region contains warm
pixels, with an example warm pixel towards the right zoomed in on. This reveals CTI trailing behind (above) the warm
Expand Down Expand Up @@ -117,7 +117,7 @@ packages `NumPy` [@numpy] and `numba` [@numba]. Dependencies also include `sciki
`scikit-learn` [@scikit-learn] and `Scipy` [@scipy].

To perform model-fitting, `PyAutoCTI` adopts the probabilistic programming
language `PyAutoFit` (https://github.com/rhayes777/PyAutoFit) [@pyautofit]. `PyAutoFit` allows users to compose a CTI
language `PyAutoFit`\footnote{https://github.com/rhayes777/PyAutoFit} [@pyautofit]. `PyAutoFit` allows users to compose a CTI
model from `Trap` and `CCD` objects, customize the model parameterization and fit it to data via a
non-linear search, for example `dynesty` [@dynesty], `emcee` [@emcee] or `PySwarms` [@pyswarms], with visualization
performed by `Matplotlib` [@matplotlib] and `corner.py` [@corner]. `PyAutoFit`'s graphical modeling framework allows one to fit a temporal model to a suite of CTI calibration data. Using a technique
Expand Down

0 comments on commit b434b75

Please sign in to comment.