This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Upgrade supported mollie client #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Uses newest mollie-api-python client - Uses v2 Mollie API, so no pressure to migrate to the new API The issue that triggered this change was that the old 1.3.2 client produced a header that the Mollie API doesn't accept anymore. For GET requests, an empty JSON body was generated (see https://github.com/mollie/mollie-api-python/blob/2e45f258fadcd3863292b89d709d41f627f7d3ff/Mollie/API/Client.py#L74), and this triggered requests (or urllib3) to produce a `Content-length: 2` header. This is incorrect since a GET request has no body, and the Mollie API apparently checks this since some time. Rather than fixing the bug in a hard way, just upgrade.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the used Mollie API client to the latest version
We ran into an issue for a legacy project that uses this integration. The
v1.x.xclient will no longer perform correct GET queries to the API, because of an ugly bug. This has been fixed in newer versions of the client.Furthermore, the v1.x.x client uses the v1 API at Mollie, which is deprecated and might be disabled after July this year