Update battle.jl #34
Merged
Update battle.jl #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BonelessPi
commented
Oct 8, 2024
BonelessPi
commented
- Pass ifempty=false to walk!() calls so that agents can start to fight
- Rename battle() to create_battlefield() to better match the purpose of the function. Also helps avoid confusion with the unrelated function battle!()
* Pass ifempty=false to walk!() calls so that agents can start to fight * Rename battle() to create_battlefield() to better match the purpose of the function. Also helps avoid confusion with the unrelated function battle!()
|
In response to #23 |
|
thanks. i assume you've run the example and the video works fine? |
Datseris
reviewed
Oct 9, 2024
docs/examples/battle.jl
Outdated
| @@ -182,7 +182,7 @@ function captor_behavior!(agent, model) | |||
| ## Prisoner runs away in the commotion | |||
| prisoner.shape = :utriangle | |||
| prisoner.capture_time = 0 | |||
| walk!(prisoner, (rand(abmrng(model), -1:1, 2)..., 0), model) | |||
| walk!(prisoner, (rand(abmrng(model), -1:1, 2)..., 0), model, ifempty=false) | |||
There was a problem hiding this comment.
Suggested change
| walk!(prisoner, (rand(abmrng(model), -1:1, 2)..., 0), model, ifempty=false) | |
| walk!(prisoner, (rand(abmrng(model), -1:1, 2)..., 0), model; ifempty=false) |
i believe it makes for a more readable code if keywords are separated by ; can you change this here and in subsequent calls?
There was a problem hiding this comment.
Added this change in new commit
battle.mp4Here's the video that it generates for me. Technically the video starts after 5 steps have already passed in the model. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.