-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake Changes #299
CMake Changes #299
Conversation
theoparis
commented
Mar 15, 2024
•
edited
Loading
edited
- Removing SHARED allows openlibm to be built statically depending on the value of BUILD_SHARED_LIBS
- Using CMAKE_CURRENT_SOURCE_DIR allows openlibm to be built via FetchContent
- I added the riscv64 architecture to openlibm's cmake build scripts
Merge? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #299 +/- ##
==========================================
+ Coverage 38.24% 39.02% +0.78%
==========================================
Files 233 233
Lines 6139 6144 +5
Branches 1607 1607
==========================================
+ Hits 2348 2398 +50
+ Misses 3394 3393 -1
+ Partials 397 353 -44 ☔ View full report in Codecov by Sentry. |
Can you rebase to master? Is this ok to merge given the changes in #302? It looks like there is no conflict. |
Hello @theoparis , could you confirm that the current git version works for you with FetchContent? Also, if you don't mind me asking, have you tried using package managers instead of FetchContent? I'm assuming you're using it to pull OpenLibm into your project |