fix _bhattacharyya_coeff signature type (#248)

Co-authored-by: Daniel Karrasch <Daniel.Karrasch@posteo.de>
JuliaStats · Mar 8, 2023 · 3b90e79 · 3b90e79 · dkarrasch · Mar 8, 2023
1 parent aae27b2
commit 3b90e79
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "Distances"
 uuid = "b4f34e82-e78d-54a5-968a-f98e89d6e8f7"
-version = "0.10.7"
+version = "0.10.8"
 
 [deps]
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

diff --git a/src/bhattacharyya.jl b/src/bhattacharyya.jl
@@ -34,11 +34,11 @@ end
     end
     return sqab, asum, bsum
 end
-@inline function _bhattacharyya_coeff(a::AbstractVector{Ta}, b::AbstractVector{Tb}) where {Ta<:Number,Tb<:Number}
-    T = typeof(sqrt(oneunit(Ta)*oneunit(Tb)))
+@inline function _bhattacharyya_coeff(a::AbstractVector, b::AbstractVector)
+    T = typeof(sqrt(oneunit(eltype(a))*oneunit(eltype(b))))
     sqab = zero(T)
-    asum = zero(Ta)
-    bsum = zero(Tb)
+    asum = zero(eltype(a))
+    bsum = zero(eltype(b))
 
     @simd for i in eachindex(a, b)
         @inbounds ai = a[i]
@@ -50,7 +50,7 @@ end
     return sqab, asum, bsum
 end
 
-@inline function _bhattacharyya_coeff(a::SparseVectorUnion{<:Number}, b::SparseVectorUnion{<:Number})
+@inline function _bhattacharyya_coeff(a::SparseVectorUnion, b::SparseVectorUnion)
     anzind = nonzeroinds(a)
     bnzind = nonzeroinds(b)
     anzval = nonzeros(a)