Fix coarse gridlines being half as wide every 8 bars. #7610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tbh, i can't see the difference between the two images. |
|
Old: |
|
Ohh i get now. Btw I don't think this fixes the actual issue, which is due to thicker lines. But thinning will confuse the user with the other lines which are also 1px. |
|
It could, but they are also a different color from the fine grid lines, so it would still work well. Here is what it would look like if both coarse and fine grid lines were 1 px: |
|
I remember telling the person who made the song editor UI change to not use 1px because it felt like 1px wouldn't create much of a difference. It still doesn't seem like the coarse and fine lines are much different. |
|
This seems like an easy merge; it's a one-character fix that objectively fixes a visual bug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #7305
This fixes the issue that every 8th bar line was half as wide. This was due to an off-by-one error where the very last bar line is not drawn. This works fine when the coarse grid lines are 1px wide, but in the default theme it is 2px, so the thinness every 8 bars is quite noticeable. This is fixed by changing
<to<=in the loop condition.Before:
After:
Note
This does not address the original issue's point that the grid lines are too thick. This simply makes them all uniform. However, the thickness can be changed in the theme style.css.
Also, I do have a fear that since floats are used in the loop, that simply changing
<to<=may not fully solve the issue. In my tested, it appears to have solved it, but I don't know.