Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐞 app crash on token selected for add account v2 redirection due to unrecognized currency on device scan #9097

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

themooneer
Copy link
Contributor

@themooneer themooneer commented Feb 3, 2025

… to unrecognized currency on device scan

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

This change fixes both App crashing when attempting to add account from token asset pages and App crashes when creating an account from the NFTs page

The main reason behind this crash, is that for token we should call the device action with the parent currency while redirecting directly to the device selection in order to make the scan correctly and avoid Invariant Violation: appName or currency or account is missing error triggered by the DeviceAction hook

screen-20250203-183525.mp4

❓ Context

  • JIRA or GitHub link:

https://ledgerhq.atlassian.net/browse/LIVE-16638

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@themooneer themooneer requested a review from a team as a code owner February 3, 2025 17:44
Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Feb 3, 2025 5:44pm
native-ui-storybook ⬜️ Ignored (Inspect) Feb 3, 2025 5:44pm
react-ui-storybook ⬜️ Ignored (Inspect) Feb 3, 2025 5:44pm
web-tools ⬜️ Ignored (Inspect) Feb 3, 2025 5:44pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Feb 3, 2025
@themooneer themooneer changed the title fix: 🐞 app crash on token selected for add account v2 redirection due… fix: 🐞 app crash on token selected for add account v2 redirection due to unrecognized currency on device scan Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants