Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable executing atm_zero_gradient_w_bdy_work on GPUs. #1272

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jim-p-w
Copy link
Contributor

@jim-p-w jim-p-w commented Jan 21, 2025

This PR enables executing the atm_zero_gradient_w_bdy_work subroutine on GPUs.
This is accomplished using OpenACC directives.

Tested with a regional test case.
Baseline results were obtained from building the develop branch with:
make -j4 nvhpc CORE=atmosphere PRECISION=single OPENACC=true
Then the changes in this PR were made and compiled in the same way.

Comparing the results stored in the restart.*.nc file showed no changes.

Note this commit adds "atm_zero_gradient_w_bdy_work [ACC_data_xfer]" timers to time the data transfers done in atm_zero_gradient_w_bdy_work, but there is no timer for the actual computation done in atm_zero_gradient_w_bdy_work.

…rk on GPUs.

Note this commit adds "atm_zero_gradient_w_bdy_work [ACC_data_xfer]" timers to
time the data transfers done in atm_zero_gradient_w_bdy_work, but there is no
timer for the actual computation done in atm_zero_gradient_w_bdy_work.
@mgduda mgduda requested review from mgduda and gdicker1 January 22, 2025 01:20
@mgduda mgduda added Atmosphere OpenACC Work related to OpenACC acceleration of code labels Jan 22, 2025
Copy link
Collaborator

@gdicker1 gdicker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Atmosphere OpenACC Work related to OpenACC acceleration of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants