Enable GPU execution of mpas_atm_get_bdy_state functions via OpenACC #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This port prepares for further changes and optimizations to follow.
Note this adds timers for OpenACC data movement in this routine, but there is no timer for the actual computation done in these functions. These timers are named: - 'mpas_atm_get_bdy_state_2d [ACC_data_xfer]' - 'mpas_atm_get_bdy_state_3d [ACC_data_xfer]'
This change will help identify memory issues when the data regions are fused across the MPAS-A dycore.
|
I structured this so that the "Add OpenACC data movement..." commit can just be reverted in the future when data regions are fused. I'm glad to change or re-work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds OpenACC directives and data movement to the
mpas_atm_get_bdy_state_2dandmpas_atm_get_bdy_state_3dfunctions.Timing information for the OpenACC data transfers in this routine is captured in the log file by new timers:
mpas_atm_get_bdy_state_2d [ACC_data_xfer].mpas_atm_get_bdy_state_3d [ACC_data_xfer].