Treat result of to_h to be hashes recursively (support config gem 3+) #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Config gem version 3.0 removed the dot access from .to_h resulting values intentionally. See: https://www.github.com/rubyconfig/config/issues/217 In config 2.2.3, the result of: ``` Api::ApiConfig.collections.to_h ``` was: ``` (byebug) Api::ApiConfig.collections.to_h {:accounts=>#<Config::Options description="Accounts", options=[:subcollection], verbs=[:get], klass="Account">, :actions=>#<Config::Options description="Actions", identifier="miq_action", options=[:collection], verbs=[:get, :put, :post, ... ``` With values being Config::Options objects. In config gem 5.5.2, they're hashes all the way down: ``` (byebug) Api::ApiConfig.collections.to_h {:accounts=>{:description=>"Accounts", :options=>[:subcollection], :verbs=>[:get], :klass=>"Account"}, :actions=>{:description=>"Actions", :identifier=>"miq_action", :options=>[:collection], :verbs=>[:get, :put, :post, :patch, :delete], ... ``` Note, if you don't convert to hash, you retain the Config::Options structure and API: ``` (byebug) Api::ApiConfig.collections ... ``` It's easy enough to change the access to assume nested hashes all the way down, which is also compatible with existing Config::Options behavior.
2 tasks
|
cc @agrare - Seems the config gem "fixed" the to_hash problem. |
Fryguy
approved these changes
Nov 26, 2024
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config gem version 3.0 removed the dot access from .to_h resulting values intentionally. See: https://www.github.com/rubyconfig/config/issues/217
In config 2.2.3, the result of:
was:
With values being Config::Options objects.
In config gem 5.5.2, they're hashes all the way down:
Note, if you don't convert to hash, you retain the Config::Options structure and API:
It's easy enough to change the access to assume nested hashes all the way down, which is also compatible with existing Config::Options behavior.