-
Notifications
You must be signed in to change notification settings - Fork 120
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactoring service retirement start_retirement method.
Refactoring Service/Retirement/StateMachines/Methods.class/methods/start_retirement.rb method with spec. This PR is based on the issue below. #8 @miq-bot add_label refactoring Made labels more descriptive and removed some useless tests as requested
- Loading branch information
1 parent
a2eb75a
commit 5559748
Showing
2 changed files
with
115 additions
and
20 deletions.
There are no files selected for viewing
60 changes: 40 additions & 20 deletions
60
...e/ManageIQ/Service/Retirement/StateMachines/Methods.class/__methods__/start_retirement.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,46 @@ | ||
# | ||
# Description: This method sets the retirement_state to retiring | ||
# | ||
module ManageIQ | ||
module Automate | ||
module Service | ||
module Retirement | ||
module StateMachines | ||
module Methods | ||
class StartRetirement | ||
def initialize(handle = $evm) | ||
@handle = handle | ||
end | ||
|
||
service = $evm.root['service'] | ||
if service.nil? | ||
$evm.log('error', "Service Object not found") | ||
exit MIQ_ABORT | ||
end | ||
def main | ||
@handle.log('info', "Service Start Retirement for #{service.inspect}.try") | ||
@handle.create_notification(:type => :service_retiring, :subject => service) | ||
service.start_retirement | ||
|
||
$evm.log('info', "Service before start_retirement: #{service.inspect} ") | ||
@handle.log('info', "Service after start_retirement: #{service.inspect} ") | ||
end | ||
|
||
if service.retired? | ||
$evm.log('error', "Service is already retired. Aborting current State Machine.") | ||
exit MIQ_ABORT | ||
end | ||
private | ||
|
||
if service.retiring? | ||
$evm.log('error', "Service is in the process of being retired. Aborting current State Machine.") | ||
exit MIQ_ABORT | ||
def service | ||
@service ||= @handle.root["service"].tap do |service| | ||
if service.nil? | ||
@handle.log(:error, 'Service Object not found') | ||
raise 'Service Object not found' | ||
end | ||
if service.retired? | ||
@handle.log(:error, 'Service is already retired. Aborting current State Machine.') | ||
raise 'Service is already retired. Aborting current State Machine.' | ||
end | ||
if service.retiring? | ||
@handle.log(:error, 'Service is in the process of being retired. Aborting current State Machine.') | ||
raise 'Service is in the process of being retired. Aborting current State Machine.' | ||
end | ||
end | ||
end | ||
end | ||
end | ||
end | ||
end | ||
end | ||
end | ||
end | ||
|
||
$evm.create_notification(:type => :service_retiring, :subject => service) | ||
service.start_retirement | ||
|
||
$evm.log('info', "Service after start_retirement: #{service.inspect} ") | ||
ManageIQ::Automate::Service::Retirement::StateMachines::Methods::StartRetirement.new.main |
75 changes: 75 additions & 0 deletions
75
...ageIQ/Service/Retirement/StateMachines/Methods.class/__methods__/start_retirement_spec.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
require_domain_file | ||
|
||
describe ManageIQ::Automate::Service::Retirement::StateMachines::Methods::StartRetirement do | ||
let(:admin) { FactoryBot.create(:user_admin) } | ||
let(:request) { FactoryBot.create(:service_retire_request, :requester => admin) } | ||
let(:service) { FactoryBot.create(:service) } | ||
let(:task) { FactoryBot.create(:service_retire_task, :destination => service, :miq_request => request) } | ||
let(:svc_task) { MiqAeMethodService::MiqAeServiceServiceRetireTask.find(task.id) } | ||
let(:svc_service) { MiqAeMethodService::MiqAeServiceService.find(service.id) } | ||
let(:root_object) do | ||
Spec::Support::MiqAeMockObject.new('service' => svc_service, | ||
'service_retire_task' => svc_task) | ||
end | ||
let(:ae_service) do | ||
Spec::Support::MiqAeMockService.new(root_object).tap do |service| | ||
current_object = Spec::Support::MiqAeMockObject.new | ||
current_object.parent = root_object | ||
service.object = current_object | ||
end | ||
end | ||
|
||
let(:svc_model_request) do | ||
MiqAeMethodService::MiqAeServiceServiceRetireRequest.find(request.id) | ||
end | ||
|
||
it "#Service retiring - good" do | ||
expect(service.retirement_state).to be_nil | ||
service.start_retirement | ||
|
||
expect(service.retirement_state).to eq("retiring") | ||
end | ||
|
||
it "starts retirement" do | ||
allow(ae_service).to receive(:create_notification) | ||
end | ||
|
||
context "with no service" do | ||
let(:root_object) do | ||
Spec::Support::MiqAeMockObject.new('service' => nil, | ||
'service_retire_task' => svc_task) | ||
end | ||
|
||
it "raises the ERROR - Service Object not found" do | ||
expect { described_class.new(ae_service).main }.to raise_error( | ||
'Service Object not found' | ||
) | ||
end | ||
end | ||
|
||
it "raises the ERROR - Service is already retired. Aborting current State Machine." do | ||
service.update( | ||
:retired => true, | ||
:retirement_last_warn => Time.zone.now, | ||
:retirement_state => "retired" | ||
) | ||
service.reload | ||
|
||
expect { described_class.new(ae_service).main }.to raise_error( | ||
'Service is already retired. Aborting current State Machine.' | ||
) | ||
end | ||
|
||
it "raises the ERROR - Service is in the process of being retired. Aborting current State Machine." do | ||
service.update( | ||
:retired => false, | ||
:retirement_last_warn => Time.zone.now, | ||
:retirement_state => "retiring" | ||
) | ||
service.reload | ||
|
||
expect { described_class.new(ae_service).main }.to raise_error( | ||
'Service is in the process of being retired. Aborting current State Machine.' | ||
) | ||
end | ||
end |