Refactoring cloud vm retirement check_deleted_from_provider method #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkanoor
reviewed
Jun 13, 2018
| @@ -1,14 +1,38 @@ | |||
| # | |||
| # Description: This method checks to see if the VM has been deleted from the provider | |||
| # Description: This method checks to see if the VM has been powered off or suspended | |||
There was a problem hiding this comment.
@pkomanek
Is this comment correct, it doesn't match the file name
|
Checked commits pkomanek/manageiq-content@05448b4~...331be3c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
mkanoor
approved these changes
Jun 15, 2018
pkomanek
deleted the
refactoring_cloud_vm_retirement_statemachines_methods_CheckDeletedFromProvider_method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
Refactoring content/automate/ManageIQ/Cloud/VM/Retirement/StateMachines/Methods.class/methods/check_deleted_from_provider.rb method and adding a new spec. This PR is based on the issue bellow.
Links
#8
@miq-bot add_label refactoring