Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zone_id to provider validationDependencies #104

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Add zone_id to provider validationDependencies #104

merged 1 commit into from
Jan 23, 2024

Conversation

agrare
Copy link
Member

@agrare agrare commented Jan 22, 2024

@agrare agrare mentioned this pull request Jan 22, 2024
Closed
15 tasks
@miq-bot
Copy link
Member

miq-bot commented Jan 22, 2024

Checked commit agrare@b2c1f5e with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@Fryguy Fryguy merged commit 9b75025 into ManageIQ:master Jan 23, 2024
3 checks passed
@Fryguy Fryguy self-assigned this Jan 23, 2024
@agrare agrare deleted the add_zone_id_to_validation_dependencies branch January 23, 2024 14:52
@Fryguy Fryguy added quinteros/yes bug Something isn't working and removed quinteros/yes? labels Jan 31, 2024
@Fryguy
Copy link
Member

Fryguy commented Jan 31, 2024

Backported to quinteros in commit 39d5a73.

commit 39d5a73496a01d5cc298c25f0e4aafdceaf91758
Author: Jason Frey <fryguy9@gmail.com>
Date:   Tue Jan 23 09:45:11 2024 -0500

    Merge pull request #104 from agrare/add_zone_id_to_validation_dependencies
    
    (cherry picked from commit 9b7502543f15c5d0eb139a4896b0dd55876c1d17)

Fryguy added a commit that referenced this pull request Jan 31, 2024
@Fryguy
Merge pull request #104 from agrare/add_zone_id_to_validation_depende…
39d5a73 
…ncies

(cherry picked from commit 9b75025)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

@gberginc gberginc Awaiting requested review from gberginc gberginc is a code owner

Assignees

@Fryguy Fryguy

Labels
bug Something isn't working quinteros/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agrare @miq-bot @Fryguy