Fill group_id when widget set is saved in dashboard.rb #7561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot assign @mzazrivec |
|
Checked commit lpichler@c6d4ad1 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
lpichler
force-pushed
the
fill_also_group_id_when_db_stored
branch
from
d5ea5a6 to
c6d4ad1
Compare
2 tasks
|
It is not needed because of before_validation from ManageIQ/manageiq#20890 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview -> Dashboards
MiqWidgetSet#group_idis same asMiqWidgetSet#owner_id(+ MiqWidgetSet#owner_type)and we are adding model validation that group has to be present in some cases.
In UI we populated send just
MiqWidgetSet#ownerand thanks to callback,MiqWidgetSet#group_idiswas also stored but it was after validation (and it is late) -so I also populated
MiqWidgetSet#group_idin controller here in this PR so validation can work correctly.this PR is required for PR
Links