[WIP] Fixed reconfigure button

[GilbertCherrie]

The reconfigure service button functionality was unintentionally removed in this PR: #8229

This PR is adding that button functionality back, however the reconfigure form is still broken and nothing renders on that page. I was thinking this should be fixed in a new PR or should just be fixed by converting this page to react all together.

[GilbertCherrie]

In order to test this PR you need to replace the line:
resource_action = service_template.resource_actions.find_by(:action => 'Reconfigure') if service_template with
resource_action = service_template.resource_actions.first in service_controller.rb.

and you need to comment out the lines:

:klass   => ApplicationHelper::Button::GenericFeatureButton,
:options => {:feature => :reconfigure}

in service_center.rb

[GilbertCherrie]

@miq-bot add_reviewer @jeffibm
@miq-bot add_reviewer @Fryguy
@miq-bot assign @jeffibm
@miq-bot add-label bug

[GilbertCherrie]

@jeffibm Can you take a look at this PR? I can't get the values @resource_action_id and @target_id to be sent to the haml file _reconfigure_form.html.haml. If this PR is too confusing and you can fix this issue another way feel free to create a new PR and I can close this one. To find the button click on one of the services below then once on the summary screen of one of them go to configuration -> reconfigure.

Also make these changes locally to get the PR to work:

In order to test this PR you need to replace the line:
resource_action = service_template.resource_actions.find_by(:action => 'Reconfigure') if service_template with
resource_action = service_template.resource_actions.first in service_controller.rb.

and you need to comment out the lines:

:klass   => ApplicationHelper::Button::GenericFeatureButton,
:options => {:feature => :reconfigure}
in service_center.rb

I don't think the form will load properly since something seems broken there and this should probably be converted to react but for now can you fix the reconfigure button so it properly gets the required values before we worry about converting to react.

[miq-bot]

Checked commits GilbertCherrie/manageiq-ui-classic@dc9083e~...3d40e67 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
5 files checked, 29 offenses detected

app/controllers/service_controller.rb

• ⚠️ - Line 240, Col 5 - Lint/UselessAssignment - Useless assignment to variable - locals.
• ❗ - Line 227, Col 7 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.
• ❗ - Line 66, Col 5 - Layout/LeadingCommentSpace - Missing space after #.

app/helpers/application_helper/toolbar/service_center.rb

• ❗ - Line 43, Col 24 - Layout/LeadingCommentSpace - Missing space after #.
• ❗ - Line 44, Col 24 - Layout/LeadingCommentSpace - Missing space after #.

app/views/service/_reconfigure_form.html.haml

• ⚠️ - Line 11 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 11 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 11 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 11 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 11 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 11 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 11 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 11 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 11 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 17 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 17 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 17 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 17 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 17 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 17 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 17 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 17 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 24 - Layout/TrailingWhitespace: Trailing whitespace detected.
• ⚠️ - Line 25 - Layout/TrailingWhitespace: Trailing whitespace detected.
• ⚠️ - Line 2 - Layout/TrailingEmptyLines: Final newline missing.
• ⚠️ - Line 2 - id attribute must be in lisp-case

app/views/service/reconfigure_dialog.html.haml

• ⚠️ - Line 1 - Layout/ExtraSpacing: Unnecessary spacing detected.
• ⚠️ - Line 1 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.
• ⚠️ - Line 2 - Layout/TrailingEmptyLines: Final newline missing.

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

[kbrock]

this PR adds the button back but the button does not work
Unsure if more functionality needs to be added back

This may be moving to React

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[miq-bot]

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

[kbrock]

@GilbertCherrie I'm guessing this is still viable. could you confirm?

[GilbertCherrie]

@kbrock I think @DavidResende0 fixed this in a different PR. Going to close this for now.