Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Convert order service form to react #8484

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GilbertCherrie
Copy link
Member

@GilbertCherrie GilbertCherrie commented Oct 13, 2022

continuing work in - #8911

This PR is blocked due to the refresh button and refresh fields options which can not be easily replicated using DDF at this moment.

Converted the Order Service Form from Angular to React. This is a dialog form which can be edited by the user so the fields will be different for each form. An example of this form being rendered is:

Before:
Screen Shot 2022-10-13 at 2 02 46 PM
Screen Shot 2022-10-13 at 2 03 22 PM

After:
Screen Shot 2022-10-13 at 2 01 58 PM
Screen Shot 2022-10-13 at 2 02 12 PM

@GilbertCherrie GilbertCherrie requested a review from a team as a code owner October 13, 2022 17:46
@GilbertCherrie GilbertCherrie changed the title Convert order service form to react [WIP] Convert order service form to react Oct 13, 2022
@GilbertCherrie GilbertCherrie mentioned this pull request Oct 29, 2022
10 tasks
@Fryguy
Copy link
Member

Fryguy commented Jan 19, 2023

Wow - this is really impressive given how complicated these forms are 👍

@jeffibm jeffibm force-pushed the convert_order_service_form branch from 8525f7b to 31da467 Compare February 17, 2023 09:07
@jeffibm
Copy link
Member

jeffibm commented Feb 22, 2023

working on the refresh button action..

image

@jeffibm
Copy link
Member

jeffibm commented Mar 29, 2023

Note : need to check if we can use the same schema in render the show page here
image

@jeffibm
Copy link
Member

jeffibm commented May 29, 2023

working on the refresh button action..

image

ToDo

  1. Refresh button click event using API
  2. Field can be refreshed

@jeffibm jeffibm force-pushed the convert_order_service_form branch from b43f548 to 3b223f5 Compare July 28, 2023 13:55
@jeffibm
Copy link
Member

jeffibm commented Aug 24, 2023

wip -

  • Progress has been made on the refresh button click events.
  • Need to find a way to populate the options from response
  • Need to find out which loaded has to be displayed when the refresh button is clicked.

image

@jeffibm
Copy link
Member

jeffibm commented Sep 1, 2023

  • Loaders are now being displayed on refresh button click events
  • Next, need a way to update the api results into the drop down fields
Screen.Recording.2023-09-01.at.11.56.47.AM.mov

@jeffibm
Copy link
Member

jeffibm commented Sep 4, 2023

Hey @GilbertCherrie ,
Updated the response (dummy data) of refresh buttons into the form

Screen.Recording.2023-09-04.at.3.26.52.PM.mov

@jeffibm jeffibm force-pushed the convert_order_service_form branch from ee272ae to 438f2e4 Compare September 6, 2023 05:24
@miq-bot
Copy link
Member

miq-bot commented Sep 6, 2023

Checked commit GilbertCherrie@438f2e4 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
5 files checked, 8 offenses detected

app/views/miq_request/_request_dialog_details.html.haml

  • ⚠️ - Line 31 - Style/ClassEqualityComparison: Use instance_of?(Integer) instead of comparing classes.
  • ⚠️ - Line 32 - Style/HashEachMethods: Use each_value instead of values.each.
  • ⚠️ - Line 34 - Style/SoleNestedConditional: Consider merging nested conditions into outer if conditions.
  • ⚠️ - Line 38 - Style/HashEachMethods: Use each_value instead of values.each.
  • ⚠️ - Line 40 - Style/SoleNestedConditional: Consider merging nested conditions into outer if conditions.
  • ⚠️ - Line 45 - Style/HashEachMethods: Use each_value instead of values.each.
  • ⚠️ - Line 47 - Style/SoleNestedConditional: Consider merging nested conditions into outer if conditions.

app/views/shared/dialogs/_dialog_user.html.haml

  • ⚠️ - Line 2 - Avoid using instance variables in partials views

@miq-bot
Copy link
Member

miq-bot commented Nov 17, 2023

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Feb 19, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

3 similar comments
@miq-bot
Copy link
Member

miq-bot commented May 20, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@miq-bot
Copy link
Member

miq-bot commented Aug 26, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@miq-bot
Copy link
Member

miq-bot commented Dec 9, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants