-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Convert order service form to react #8484
base: master
Are you sure you want to change the base?
[WIP] Convert order service form to react #8484
Conversation
Wow - this is really impressive given how complicated these forms are 👍 |
8525f7b
to
31da467
Compare
b43f548
to
3b223f5
Compare
Screen.Recording.2023-09-01.at.11.56.47.AM.mov |
Hey @GilbertCherrie , Screen.Recording.2023-09-04.at.3.26.52.PM.mov |
ee272ae
to
438f2e4
Compare
Checked commit GilbertCherrie@438f2e4 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint app/views/miq_request/_request_dialog_details.html.haml
app/views/shared/dialogs/_dialog_user.html.haml
|
This pull request is not mergeable. Please rebase and repush. |
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
3 similar comments
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
continuing work in - #8911
This PR is blocked due to the refresh button and refresh fields options which can not be easily replicated using DDF at this moment.
Converted the Order Service Form from Angular to React. This is a dialog form which can be edited by the user so the fields will be different for each form. An example of this form being rendered is:
Before:
After: