[WIP] Catalog de explorization

[jeffibm]

Related PR's
Core - ManageIQ/manageiq#22275

Service Catalogs
Before

After - will be added later

Catalog Items
Before

After - will be added later

Orchestration Templates
Before

After - will be added later

Catalogs
Before

After - will be added later

[jeffibm]

Fixed the breadcrumb issue.

Screen.Recording.2023-11-10.at.10.17.31.AM.mov

[miq-bot]

Some comments on commit jeffbonson@ee6dde5

app/controllers/catalog_controller.rb

• ⚠️ - 2307 - Detected puts. Remove all debugging statements.
• ⚠️ - 2362 - Detected puts. Remove all debugging statements.

[miq-bot]

Checked commit jeffbonson@ee6dde5 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
17 files checked, 38 offenses detected

app/controllers/application_controller/explorer.rb

• ❗ - Line 157, Col 1 - Layout/TrailingWhitespace - Trailing whitespace detected.

app/controllers/catalog_controller.rb

• ⚠️ - Line 356, Col 5 - Lint/Debugger - Remove debugger entry point byebug.
• ❗ - Line 106, Col 37 - Rails/WhereEquals - Use where(id: params[:item].to_i) instead of manually constructing SQL.
• ❗ - Line 2307, Col 5 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.
• ❗ - Line 2362, Col 19 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.

app/controllers/service_template_catalog_controller.rb

• ⚠️ - Line 81, Col 49 - Lint/AmbiguousOperatorPrecedence - Wrap expressions with varying precedence with parentheses to avoid ambiguity.
• ⚠️ - Line 81, Col 8 - Lint/AmbiguousOperatorPrecedence - Wrap expressions with varying precedence with parentheses to avoid ambiguity.
• ❗ - Line 56, Col 1 - Layout/EmptyLines - Extra blank line detected.
• ❗ - Line 74, Col 1 - Layout/TrailingWhitespace - Trailing whitespace detected.
• ❗ - Line 8, Col 1 - Layout/EmptyLines - Extra blank line detected.

app/helpers/application_helper.rb

• ❗ - Line 261, Col 16 - Style/StringConcatenation - Prefer string interpolation to string concatenation.

app/helpers/application_helper/toolbar/servicetemplatecatalog_center.rb

• ❗ - Line 16, Col 11 - Layout/HashAlignment - Align the keys and values of a hash literal if they span more than one line.

app/presenters/menu/default_menu.rb

• ❗ - Line 61, Col 11 - Layout/FirstArrayElementIndentation - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.
• ❗ - Line 61, Col 133 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 61, Col 61 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 61, Col 88 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 65, Col 9 - Layout/FirstArrayElementIndentation - Indent the right bracket the same as the first position after the preceding left parenthesis.
• ❗ - Line 68, Col 1 - Layout/EmptyLines - Extra blank line detected.
• ❗ - Line 73, Col 29 - Layout/LeadingCommentSpace - Missing space after #.

app/views/catalog/_sandt_tree_show.html.haml

• ⚠️ - Line 1 - Avoid using instance variables in partials views
• ⚠️ - Line 1 - Line is too long. [163/80]

app/views/catalog/_summary.html.haml

• ⚠️ - Line 12 - Line is too long. [95/80]
• ⚠️ - Line 13 - Line contains trailing whitespace
• ⚠️ - Line 20 - Line contains trailing whitespace
• ⚠️ - Line 23 - Line is too long. [133/80]
• ⚠️ - Line 29 - Line contains trailing whitespace
• ⚠️ - Line 5 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
• ⚠️ - Line 6 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
• ⚠️ - Line 8 - Classes should be listed before IDs (.miq_custom_tabs_container should precede #catalog-tabs)

app/views/catalog/catalog_item.html.haml

• ⚠️ - Line 1 - Line is too long. [163/80]

app/views/service_template_catalog/new.html.haml

• ⚠️ - Line 3 - Layout/SpaceInsideHashLiteralBraces: Space inside { detected.
• ⚠️ - Line 3 - Layout/SpaceInsideHashLiteralBraces: Space inside } detected.

app/views/service_template_catalog/show.html.haml

• ⚠️ - Line 16 - Line is too long. [98/80]
• ⚠️ - Line 18 - Line is too long. [129/80]
• ⚠️ - Line 19 - Layout/LeadingCommentSpace: Missing space after #.
• ⚠️ - Line 19 - Use -# for comments instead of - #

app/views/service_template_catalog/show_list.html.haml

• ⚠️ - Line 1 - id attribute must be in lisp-case

config/routes.rb

• ❗ - Line 2776, Col 16 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).