-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for custom button action events #8930
Conversation
547d69d
to
3cc1a24
Compare
@jeffibm do you have an example of a simple button that I could create to test? Mine say the've launched but I can't tell if they're actually executing correctly. |
@@ -33,9 +33,20 @@ def button | |||
service_retire | |||
when 'service_retire_now' | |||
service_retire_now | |||
when "custom_button" | |||
@display == 'generic_objects' ? generic_object_custom_buttons : custom_buttons |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we raise here in an else case with a generic "not supported" warning? I assume before this change, it didn't do anything when you clicked the button. What's the best way to handle a button with no defined action?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
53e715e
to
b518fbc
Compare
Fix for custom button action events
cfac16f
to
4137588
Compare
Checked commit jeffbonson@4137588 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
Hey @jrafanie , if this PR is good, can we merge it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jeffibm can you add backport labels? |
Backported to
|
Fix for custom button action events (cherry picked from commit 41db630)
Before
When we hit the custom buttons from the Service#show page, there was no action.
After
The custom button actions are now working and being redirected to another page...