Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new dedicated my_settings_view permission #8957

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Nov 7, 2023

@miq-bot
Copy link
Member

miq-bot commented Nov 7, 2023

Checked commit Fryguy@b159173 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 👍

@Fryguy Fryguy changed the title Use new dedicated my_settings_view permission [WIP] Use new dedicated my_settings_view permission Nov 7, 2023
@Fryguy
Copy link
Member Author

Fryguy commented Nov 7, 2023

@kbrock There are still issues where Time profiles tab shows up, but then you get errors when you click. I can't tell if it's because there are premission needed just to switch tabs (which makes no sense to me), or if the API's permissions don't match the UI's permissions.

That being said, it might be worth merging this anyway, and fixing that in a follow up.

@Fryguy Fryguy added the bug label Nov 7, 2023
@miq-bot miq-bot added the wip label Nov 7, 2023
@Fryguy Fryguy changed the title [WIP] Use new dedicated my_settings_view permission Use new dedicated my_settings_view permission Nov 14, 2023
@miq-bot miq-bot removed the wip label Nov 14, 2023
@Fryguy Fryguy closed this Nov 14, 2023
@Fryguy Fryguy reopened this Nov 14, 2023
@kbrock kbrock merged commit 7b6b739 into ManageIQ:master Nov 14, 2023
7 checks passed
@Fryguy Fryguy deleted the my_settings_fix branch November 14, 2023 23:18
@Fryguy
Copy link
Member Author

Fryguy commented Nov 14, 2023

Backported to quinteros in commit 726f332.

commit 726f332ed7841a32f098b4588a42777b8d71fd1b
Author: Keenan Brock <keenan@thebrocks.net>
Date:   Tue Nov 14 18:10:15 2023 -0500

    Merge pull request #8957 from Fryguy/my_settings_fix
    
    Use new dedicated my_settings_view permission
    
    (cherry picked from commit 7b6b73925027a05a5dac460b3a6c3df20d2e48e7)

Fryguy pushed a commit that referenced this pull request Nov 14, 2023
Use new dedicated my_settings_view permission

(cherry picked from commit 7b6b739)
@pint2oo
Copy link

pint2oo commented Nov 15, 2023

Hi! Thanks for the fix! 😄 Any way to backport it to Petrosian, by any chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

My Settings Error
4 participants