Upgrade font-awesome-sass to v6 #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- FontAwesome split out brands into its own group called `fa-brands` - The base `fa` prefix should now be `fa-solid` - Other minor changes to better conform with the way FontAwesome is supposed to be used
|
Note that I did not change the old documentation in this PR, because I want to see if I can just regenerate it, and it's a lot of churn. Additionally, the old docs are broken at the moment anyway (can't be linked to), so I need to figure that out first. |
|
Also note that this introduces a ton of warnings, but they are ok. I plan to fix as many as I can in future PRs |
github-actions bot
pushed a commit
to ManageIQ/manageiq.github.io
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fa-brandsfaprefix should now befa-solid@jrafanie Please review.
This should obviate #1175