[WIP] Drop unused LifecycleEvent model

[jrafanie]

This was added back in 2008 in commit d866a691c57073d44d24eba284f962e62f87a706
and isn't used. It was never reportable but was available in the API.

Part of #21204

• Depends on the API change to drop access to this model's data.
• Goes along with the schema change to drop the table and remove the id column from the vms table

[Fryguy]

FYI @chessbyte - Maybe you remember this?

[chessbyte]

Maybe @gmcculloug or @gtanzillo remember that far back. If nothing is updating it, I would drop this.

[jrafanie]

Maybe @gmcculloug or @gtanzillo remember that far back. If nothing is updating it, I would drop this

TLDR; I very much think this is unused. It was added for the old soap based vmdbws controller, the precursor to the rest api.
I laid out the whole deletion in #21204 if interested in stealing some deletions. 😉 I'll get to it but some other brokenness is taking priority right now.

[Fryguy]

Looks good to me - seems you just have some other PRs in other repos?

[jrafanie]

Looks good to me - seems you just have some other PRs in other repos?

yeah, I'll get back to this eventually

[kbrock]

I see:

• manageiq_apis/spec/requests/vms_spec.rb:1240
• manageiq-schema/spec/support/table_list.txt:136
• schema.rb

[kbrock]

this looks like a great change.

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

[miq-bot]

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

[miq-bot]

Checked commit jrafanie@7dfee40 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. ⭐

[kbrock]

heh. this links to travis. guess that is really saying how old this is

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[kbrock]

Can we merge this?
The API PR has been merged and I don't see any references to lifecycle_events.

I think merging this even before the schema changes is still good.

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).