Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw more accurate circular Arcs for larger angles #4034

Merged
merged 2 commits into from
Jan 19, 2025

Conversation

chopan050
Copy link
Contributor

@chopan050 chopan050 commented Dec 1, 2024

Closes #3344

In the source code itself, there are only 3 additions and 2 deleted lines. However, this PR required regenerating control data frames for 187 tests which used Circles, Arcs, Texes, SVGMobjects and others.

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement, thank you very much!

@behackl behackl enabled auto-merge (squash) January 19, 2025 18:01
@behackl behackl added the enhancement Additions and improvements in general label Jan 19, 2025
@behackl behackl added this to the v0.19.0 milestone Jan 19, 2025
@behackl behackl merged commit 8bb28aa into ManimCommunity:main Jan 19, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Additions and improvements in general
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Circular arcs are inaccurate for large angles
2 participants